convert : sort and use file parts from model index if present#18043
Merged
convert : sort and use file parts from model index if present#18043
Conversation
CISC
commented
Dec 15, 2025
Member
Author
|
@ngxson gentle ping |
ngxson
approved these changes
Dec 17, 2025
Contributor
There was a problem hiding this comment.
btw, I think it's probably better to make this whole index_tensors() function to be less complicated, by refactor it into 3 separated cases (can be done in a follow-up PR):
- safetensors non-mistral --> most models use this
- safetensors mistral --> probably expose as a function that can be override by subclass, similar to
modify_tensors() .binfile
compilade
approved these changes
Dec 17, 2025
CISC
changed the title
Anico2
added a commit
to Anico2/llama.cpp
that referenced
this pull request
Jan 15, 2026
…rg#18043) * keep file part order from model index * treat index as authoritative * sort index parts
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
* keep file part order from model index * treat index as authoritative * sort index parts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #17286
The previous PR made tensor order more random than necessary, if there's an index,
keep the same file orderuse a sorted list of all unique file parts from there, if not keep the sorted order fromget_model_part_namesfor consistent conversions.