Skip to content

preset: handle negated arg, reverse the meaning if needed#18041

Merged
ngxson merged 1 commit intomasterfrom
xsn/preset_fix_neg_arg
Dec 14, 2025
Merged

preset: handle negated arg, reverse the meaning if needed#18041
ngxson merged 1 commit intomasterfrom
xsn/preset_fix_neg_arg

Conversation

@ngxson
Copy link
Copy Markdown
Contributor

@ngxson ngxson commented Dec 14, 2025

Fix #18038

Should work on all these cases:

mmap = 0 --> disable mmap
mmap = 1 --> enable mmap
no-mmap = 0 --> enable mmap
no-mmap = 1 --> disable mmap

@ngxson ngxson mentioned this pull request Dec 14, 2025
Closed
@ngxson ngxson merged commit 5239229 into master Dec 14, 2025
69 of 70 checks passed
Anico2 added a commit to Anico2/llama.cpp that referenced this pull request Jan 15, 2026
@Anico2
preset: handle negated arg, reverse the meaning if needed (ggml-org#1…
7057a0f 
…8041)
blime4 referenced this pull request in blime4/llama.cpp Feb 5, 2026
@ngxson
preset: handle negated arg, reverse the meaning if needed (#18041)
d306200
@wallentri88 wallentri88 mentioned this pull request Feb 24, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CISC CISC CISC approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Misc. bug: "--models-preset config.ini" doesn't accept the --no-mmap argument

2 participants

@ngxson @CISC