models : fix YaRN regression + consolidate logic#18006
Merged
Conversation
CISC
reviewed
Dec 13, 2025
CISC
reviewed
Dec 13, 2025
CISC
approved these changes
Dec 13, 2025
Anico2
added a commit
to Anico2/llama.cpp
that referenced
this pull request
Jan 15, 2026
* models : fix YaRN regression + consolidate logic * cont : fix the fix * cont : remove header * cont : add header
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
* models : fix YaRN regression + consolidate logic * cont : fix the fix * cont : remove header * cont : add header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cont #17945
fix #18004
In #17945, accidentally broke all models that don't define
rope_yarn_log_mul(a.k.a.mscale_all_dims), such asgpt-oss.