kv-cache: Fix state restore fragmented cache#17982
Merged
ggerganov merged 6 commits intoggml-org:masterfrom Dec 15, 2025
Merged
kv-cache: Fix state restore fragmented cache#17982ggerganov merged 6 commits intoggml-org:masterfrom
ggerganov merged 6 commits intoggml-org:masterfrom
Conversation
Change find_slot to allow non-contiguous allocation during state restore. Fixes 'failed to find available cells in kv cache' error when restoring state to fragmented cache.
Contributor
Author
|
PS - aimed to implement the direction given by @ggerganov (#17527 (comment)) |
Member
|
Looking good - will do some testing to confirm 👍 |
ggerganov
reviewed
Dec 15, 2025
Member
|
I updated the test to do a proper verification:
@ssweens After you address the comments, we can merge. |
ggerganov
reviewed
Dec 15, 2025
Contributor
Author
|
Thanks @ggerganov. Comments addressed and committed. |
ggerganov
approved these changes
Dec 15, 2025
Member
ggerganov
left a comment
ggerganov
left a comment
There was a problem hiding this comment.
Thanks for the contribution. This is a good improvement.
Contributor
Author
|
Happy to help where/when I can. Hat tip to you and team on the great project. |
Anico2
added a commit
to Anico2/llama.cpp
that referenced
this pull request
Jan 15, 2026
* kv-cache : fix state restore with fragmented cache (ggml-org#17527) Change find_slot to allow non-contiguous allocation during state restore. Fixes 'failed to find available cells in kv cache' error when restoring state to fragmented cache. * tests : update logic * cleanup: tightened state_read_meta sig, added is_contiguous case * fix: state_read_meta arg reorder loose ends --------- Co-authored-by: Georgi Gerganov <[email protected]>
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
* kv-cache : fix state restore with fragmented cache (#17527) Change find_slot to allow non-contiguous allocation during state restore. Fixes 'failed to find available cells in kv cache' error when restoring state to fragmented cache. * tests : update logic * cleanup: tightened state_read_meta sig, added is_contiguous case * fix: state_read_meta arg reorder loose ends --------- Co-authored-by: Georgi Gerganov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #17527
Change find_slot to allow non-contiguous allocation during state restore. Fixes 'failed to find available cells in kv cache' error when restoring state to fragmented cache.