mtmd: explicitly forbidden inclusion of private header and libcommon#17946
Merged
ngxson merged 1 commit intoggml-org:masterfrom Dec 12, 2025
Merged
mtmd: explicitly forbidden inclusion of private header and libcommon#17946ngxson merged 1 commit intoggml-org:masterfrom
ngxson merged 1 commit intoggml-org:masterfrom
Conversation
Contributor
Author
|
pinging @ggerganov in case you missed this PR |
ggerganov
approved these changes
Dec 12, 2025
Anico2
added a commit
to Anico2/llama.cpp
that referenced
this pull request
Jan 15, 2026
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a foolproof solution against misuse of internal mtmd headers and libcommon
These changes can potentially be overlooked on some PRs when there are a lot of code changing. Notably #16910 ; other examples can be: #17223, #17914