Webui: Disable attachment button and model selector button when prompt textbox is disabled.#17925
Conversation
selector button.
allozaur
left a comment
allozaur
left a comment
There was a problem hiding this comment.
Hey, thanks for the fix! :) Just please include updated static build in the PR and then we can move forward with this.
Thanks for the comment. I'm assuming this is the build artifact you are referring to? |
Yes, please run |
|
Ah, oops. I didn't realize it got committed to the repo. Should be there now. |
|
Hold up, something is wrong with the model selector. I'm looking into it now. |
|
Ok, I think the issue I was seeing was caused by a commit yesterday that disabled the model selector drop-down when running in non-router mode. This prevented the onclick callback from firing and incorrectly showed the model card button as disabled. I made a commit which should fix this. |
allozaur
left a comment
allozaur
left a comment
There was a problem hiding this comment.
@dariusjlukas ideally if you could just add a videos instead of screenshots in the PR description :) and please rebase and rebuild webui static output
Ask and you shall receive ;) |
…t textbox is disabled. (ggml-org#17925) * Pass disabled state to the file attachments button and the model selector button. * Update index.html.gz * Fix model info card in non-router mode. * Update index.html.gz
…t textbox is disabled. (#17925) * Pass disabled state to the file attachments button and the model selector button. * Update index.html.gz * Fix model info card in non-router mode. * Update index.html.gz
2 participants
Description
Prevent the user from interacting with either the attachment button or the model selector button when the chat text input is disabled.
Changes
Pass the disabled state to the file attachment's DropdownMenu Trigger and to the ModelsSelector.