ci : skip winget update when not in ggml-org#17465
Conversation
Prevent forks from generating daily failure notifications. Signed-off-by: Adrien Gallouët <[email protected]>
| update: | ||
| name: Update Winget Package | ||
| runs-on: ubuntu-latest | ||
| if: ${{ github.repository.owner.login == 'ggml-org' }} |
There was a problem hiding this comment.
Could check if secrets.WINGET_GITHUB_TOKEN exists instead.
There was a problem hiding this comment.
Sorry, just found my last comment disappeared (I did something wrong with github I guess..) so let me resume my last comment:
Checking secrets.WINGET_GITHUB_TOKEN would not fix my issue as the build will fail before for various reasons (no release, no tags, etc).
But also this step has no value outside of ggml-org and explicitly use it:
llama.cpp/.github/workflows/winget.yml
Line 39 in 6ab4e50
In the scenario where the action is performed under ggml-org, I believe a red notification would be beneficial if the secret is missing.
|
Looks like @/slaren is on hiatus as stated here: #17639 (comment) Pinging @CISC for a review instead :) |
|
|
Why? Docker builds work on forks. |
|
@angt I don't know why, but it doesn't work... |
sad... i was not able to test this :( going to dig that, sorry! |
|
see #17790 |
Prevent forks from generating daily failure notifications. Signed-off-by: Adrien Gallouët <[email protected]>
Prevent forks from generating daily failure notifications. Signed-off-by: Adrien Gallouët <[email protected]>

Prevent forks from generating daily failure notifications.