use max work group size for device to replace the magic number#14732
Merged
NeoZhangJianyu merged 1 commit intoggml-org:masterfrom Jul 18, 2025
Merged
Conversation
github-actions
bot
added
ggml
Rbiessy
approved these changes
Jul 17, 2025
Contributor
Rbiessy
left a comment
Rbiessy
left a comment
There was a problem hiding this comment.
Thanks for the fix that looks good to me.
Alcpz
approved these changes
Jul 17, 2025
qnixsynapse
approved these changes
Jul 17, 2025
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Jul 21, 2025
blime4
referenced
this pull request
in blime4/llama.cpp
Feb 5, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #14689
use max work group size for device to replace the magic number.
The magic number 768 is copied from CUDA code.
It will lead to issue "invalid work-group size" on Intel iGPU with less work group size.