ggml: fix GGML_UNARY_OP_NAME order to align with enum ggml_unary_op#13717
Closed
lhez wants to merge 1 commit intoggml-org:masterfrom
Closed
ggml: fix GGML_UNARY_OP_NAME order to align with enum ggml_unary_op#13717lhez wants to merge 1 commit intoggml-org:masterfrom
GGML_UNARY_OP_NAME order to align with enum ggml_unary_op#13717lhez wants to merge 1 commit intoggml-org:masterfrom
Conversation
github-actions
bot
added
the
ggml
Contributor
|
That was a mistake from #13667 , we should change the enum instead, I do that in the other PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The names order in
GGML_UNARY_OP_NAMEmismatches that inenum ggml_unary_op. This causes problem when unit testing a specific unary op by passing the unary op name totest-backend-ops.