server : (UI) fix missing async generator on safari#10857
Merged
ngxson merged 2 commits intoggml-org:masterfrom Dec 17, 2024
Merged
server : (UI) fix missing async generator on safari#10857ngxson merged 2 commits intoggml-org:masterfrom
ngxson merged 2 commits intoggml-org:masterfrom
Conversation
ggerganov
approved these changes
Dec 17, 2024
Member
ggerganov
left a comment
ggerganov
left a comment
There was a problem hiding this comment.
Tested Safari on MacOS and it works.
examples/server/webui/src/main.js
Outdated
| showTokensPerSecond: false, | ||
| // make sure these default values are in sync with `common.h` | ||
| samplers: 'edkypmxt', | ||
| samplers: 'dkypmxt', |
Member
There was a problem hiding this comment.
This should not be changed. With #10803, the penalties sampler has to be manually inserted, instead of always being present at the start.
Contributor
Author
There was a problem hiding this comment.
Ah yeah, I took the incorrect base branch. Fixed now, thanks!
Member
|
Btw, the "Copy" button on code blocks no longer seems to work. It throws this error in the console: 
|
Contributor
Author
|
There are some limitations to the The solution is to fallback to |
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Dec 20, 2024
* server : (UI) fix missing async generator on safari * fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #10841 and #10842
Caused by missing
ReadableStreamasync iterator support on safari: https://caniuse.com/mdn-api_readablestream_--asynciteratorIt's now working thanks to the ponyfill