server : (web UI) add copy button for code block, fix api key#10242
server : (web UI) add copy button for code block, fix api key#10242ngxson merged 5 commits intoggml-org:masterfrom
Conversation
There was a problem hiding this comment.
There is a subtle bug with the scrolling:
- Scroll to the bottom of the generated session (or to the top)
- Using a mouse with scroll wheel, first start scrolling down and then up - nothing happens
- If you first scroll up and the down - it works
Edit: please ignore - everything is OK
|
@ggerganov I'm not sure if I understand it correctly, but I suspect that it may have something to do with the "show-on-hover" that I have on the button. I removed that in the last commit, so the copy button now always show on code snippet (no need to hover). Please let me know if that fixes the issue. Thanks. |
|
Ah, apologies for the distraction - this seems to be a browser behaviour that somehow I haven't noticed before. All scrolls on other pages also work like that, so it's not specific to this UI. |
|
No problem. Anw, I think having the copy button being persistent (and not "on hover") feels more consistent overall, so I'll keep it and merge this PR now. Thanks for testing it! |
…rg#10242) * server : (web ui) add copy btn for code blocks * fix problem with api key * use settings-modal-short-input component * always show copy btn for code snippet
…rg#10242) * server : (web ui) add copy btn for code blocks * fix problem with api key * use settings-modal-short-input component * always show copy btn for code snippet
…rg#10242) * server : (web ui) add copy btn for code blocks * fix problem with api key * use settings-modal-short-input component * always show copy btn for code snippet
3 participants
Added Copy button for code blocks:
It also follow the window as user scroll up (position sticky):
This PR also fixes a problem with API key set, as reported via this comment: #10175 (comment)