ggml : add ggml_fft and ggml_ifft operator#1105
Open
ilhamsyahids wants to merge 4 commits intoggml-org:masterfrom
Open
ggml : add ggml_fft and ggml_ifft operator#1105ilhamsyahids wants to merge 4 commits intoggml-org:masterfrom
ggml_fft and ggml_ifft operator#1105ilhamsyahids wants to merge 4 commits intoggml-org:masterfrom
Conversation
Signed-off-by: Ilham Syahid S <ilhamsyahids@gmail.com>
Signed-off-by: Ilham Syahid S <ilhamsyahids@gmail.com>
This commit adds a new test file `test-fft.c` to validate the FFT and IFFT implementations. The test generates a simple sinusoidal signal, performs a forward FFT followed by an inverse FFT, and checks that the reconstructed signal matches the original signal within a specified tolerance. Signed-off-by: Ilham Syahid S <ilhamsyahids@gmail.com>
Author
|
Hello @ggerganov @slaren is there any review or comment regarding this PR? |
Member
|
Hi @ilhamsyahids - thank you for the contribution. It's not forgotten and I will try to make a review soon. |
Member
|
Hey @ilhamsyahids, I thought further about this functionality, and decided that for now it is not worth to add it to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements FFT and IFFT operator on CPU. I also added simple test apply FFT and inverse it.
I'm kinda new with this, so I'm happy to adjust and apply any review