ggml-cpu: Add bounds checking in make_block_q4_0x4 function#1095
Open
ilhamsyahids wants to merge 2 commits intoggml-org:masterfrom
Open
ggml-cpu: Add bounds checking in make_block_q4_0x4 function#1095ilhamsyahids wants to merge 2 commits intoggml-org:masterfrom
make_block_q4_0x4 function#1095ilhamsyahids wants to merge 2 commits intoggml-org:masterfrom
Conversation
Prevent potential buffer overflows by adding explicit bounds checking when copying memory in the `make_block_q4_0x4` function Signed-off-by: Ilham Syahid S <ilhamsyahids@gmail.com>
Refactor the memory copying logic in the `make_block_q4_0x4` function to remove explicit bounds checking Use compile-time constants and loop bounds to prevent potential buffer overflows. Signed-off-by: Ilham Syahid S <ilhamsyahids@gmail.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent potential buffer overflows by adding explicit bounds checking when copying memory in the
make_block_q4_0x4functionmake_block_q4_0x4#1094after: