Merged
Conversation
6 tasks
44 tasks
Collaborator
Author
|
Unfortunately it seems the CI doesn't support mesh shaders, since I think it only supports Metal2. So we won't get that advantage. Related, I believe I've uncovered a logical error in feature detection for int64 and scoped simd, will report |
Member
|
Laaame, alright |
Collaborator
Author
|
@cwfitzgerald I didn't probably address all your comments correctly but can you take a look at what I said |
f70a35c to
7219f95
Compare
6 tasks
cwfitzgerald
requested changes
Nov 12, 2025
Member
cwfitzgerald
left a comment
There was a problem hiding this comment.
Much better, some more cleanup comments, then we should be good.
Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
cwfitzgerald
approved these changes
Nov 15, 2025
Member
|
Tests pass, cts passes, lets do this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Related #7197
Similar to #8110
Description
Adds mesh shaders to metal backend
Testing
None yet
Squash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.