This repository was archived by the owner on Dec 17, 2024. It is now read-only.
Terminate VM on get_task() when already assigned with Task #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two major changes in this commit:
- Terminate the VM if it queries for a new task when it already has
a task assigned (in running_tasks).
- Fix the `task_queue` operation: `front()` -> `pop_front()`.
- When pulling a task from the queue, it must be removed from it to
prevent re-execution. This mistake happened to accidentally work
because the VM was stopped after successful task execution (so it
didn't ask for a new task again).
musitdev
approved these changes
Feb 21, 2024
tuommaki
deleted the
terminate-vm-on-get_task-when-already-running-task
branch
musitdev
added a commit
that referenced
this pull request
Feb 22, 2024
* first implementation * correct file management. Work locally. Before remote test * correct p2p peer list init * add some logs to follow tx * correct rebase error * add checksum to VM file and test * add type state to file and Tx * correct some issues in file path * add some logs * update proof generated file path * remove comments * add comment, add timeout and error management to http download connection * correct http url definition * add timeout to http send * add better download error login and log file checksum * correct build * desactivate checksum verification for downloaded files * add some logs for checksum * change hasher for VM file and activate checksum verification * correct host detection for download * disable proof and verifcation workflow and remove some logs * rebase from master and correct download file issue * rebase from master and correct download file issue * pass clippy and tests * correct clippy * do some cleaning * correct PR remarks * add newline to be like the original file * change generated file name from uuid to checksum * Avoid to move download existing file * correct clippy * remove asset manager call to test * correct some path issue * add verify tx execution in the workflow. * add mark deploy tx as executed * remove the dbg! that panic * change verif tx workflow management and change logs * Terminate VM on get_task() when already assigned with Task (#96) Two major changes in this commit: - Terminate the VM if it queries for a new task when it already has a task assigned (in running_tasks). - Fix the `task_queue` operation: `front()` -> `pop_front()`. - When pulling a task from the queue, it must be removed from it to prevent re-execution. This mistake happened to accidentally work because the VM was stopped after successful task execution (so it didn't ask for a new task again). * revert .gitignore change * correct mutex lock issue * remove asset management and some logs --------- Co-authored-by: Tuomas Mäkinen <1947505+tuommaki@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two major changes in this commit:
task_queueoperation:front()->pop_front().