feat: add explore equation to dashboards #99404
Conversation
github-actions
bot
added
the
Scope: Frontend
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
nikkikapadia
left a comment
nikkikapadia
left a comment
There was a problem hiding this comment.
overall looks good to me, just one comment about flagging
| defaultField: DEFAULT_FIELD, | ||
| defaultWidgetQuery: DEFAULT_WIDGET_QUERY, | ||
| enableEquations: false, | ||
| enableEquations: true, |
There was a problem hiding this comment.
should we be conditionally allowing it based on feature flag? i know we have the visibility-explore-equations flag which doesn't seem to be fully rolled out yet 🤔
There was a problem hiding this comment.
The add equation button is flagged https://github.com/getsentry/sentry/pull/99404/files#diff-0559dfcce1f9b988a4626e5d7c6624642aa77322acee5f3e4e593614d5e96b57R869-R871, I think that should be good enough?
There was a problem hiding this comment.
oh whoopsies i missed that, yup should be good 👍
shruthilayaj
deleted the
shruthi/feat/add-explore-equation-to-dashboards
branch
Adds explore equations to the spans dataset. Note that the spans backend API
does not support the equation index alias format (ie
equation[0]) in the sorts.So we are converting it into the function format before we make the table or stats
request.