feat(trace-eap-waterfall): Exclude missing instrumentation nodes from FE traces #97879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
edwardgou-sentry
approved these changes
Aug 14, 2025
priscilawebdev
pushed a commit
that referenced
this pull request
Aug 25, 2025
… FE traces (#97879) - node.event is undefined for eap span nodes since it corresponds to the nodestore transaction event json in non-eap span nodes - we can just use sdk name from the `/trace/` response Co-authored-by: Abdullah Khan <[email protected]>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 26, 2025
… FE traces (#97879) - node.event is undefined for eap span nodes since it corresponds to the nodestore transaction event json in non-eap span nodes - we can just use sdk name from the `/trace/` response Co-authored-by: Abdullah Khan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/trace/response