feat(otlp): Use name attribute in more spaces in the span waterfall
#97704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another UI update - always show `span.op` unless it's `"default"` (same as current behaviour) - if OTel UI is on, show the span _name_. If span name is not available, fall back to _description_ This creates decent behaviour for traces that contain both OTLP and Sentry spans.
This is a more semantic way to access the query than the description, it should be the first place to look.
When showing the span details section, for OTLP, use `span.name` which will always be present.
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Abdkhan14
approved these changes
Aug 14, 2025
gggritso
deleted the
georgegritsouk/ope-62-favor-spanname-in-the-trace-waterfall
branch
priscilawebdev
pushed a commit
that referenced
this pull request
Aug 25, 2025
…#97704) A few more visual updates to the span waterfall for those using OTel-friendly UI: 1. Update the span tree again. This time, bring it back closer to show it originally worked. Always show `span.op` (unless it's `"default"`). Show the span name if using OTel UI, otherwise show span description 2. Favour `db.query.text` attribute when creating a formatted description. This is a semantic attribute that contains the entire query, it should be used first 3. For OTel UI, show the span name in place of the span description in the span description section of the details panel 4. When making a "More Samples" link for OTel UI, create the query by using the `span.name` attribute instead of `span.description
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 26, 2025
…#97704) A few more visual updates to the span waterfall for those using OTel-friendly UI: 1. Update the span tree again. This time, bring it back closer to show it originally worked. Always show `span.op` (unless it's `"default"`). Show the span name if using OTel UI, otherwise show span description 2. Favour `db.query.text` attribute when creating a formatted description. This is a semantic attribute that contains the entire query, it should be used first 3. For OTel UI, show the span name in place of the span description in the span description section of the details panel 4. When making a "More Samples" link for OTel UI, create the query by using the `span.name` attribute instead of `span.description
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few more visual updates to the span waterfall for those using OTel-friendly UI:
span.op(unless it's"default"). Show the span name if using OTel UI, otherwise show span descriptiondb.query.textattribute when creating a formatted description. This is a semantic attribute that contains the entire query, it should be used firstspan.nameattribute instead of `span.description