Skip to content

fix(stories): update footer navigation #95582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2025
Merged

fix(stories): update footer navigation #95582

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
676ef2b
fix(stories): use story location in footer
natemoo-re Jul 15, 2025
20119a8
ref(stories): flatten data model
natemoo-re Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 15 additions & 33 deletions static/app/stories/view/storyFooter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,51 +1,36 @@
import styled from '@emotion/styled';
import qs from 'query-string';

import {LinkButton} from 'sentry/components/core/button/linkButton';
import {Flex} from 'sentry/components/core/layout';
import {IconArrow} from 'sentry/icons';
import {useStoryBookFilesByCategory} from 'sentry/stories/view/storySidebar';
import type {StoryTreeNode} from 'sentry/stories/view/storyTree';
import type {StoryDescriptor} from 'sentry/stories/view/useStoriesLoader';
import {useStory} from 'sentry/stories/view/useStory';
import {space} from 'sentry/styles/space';
import {useLocation} from 'sentry/utils/useLocation';

export function StoryFooter() {
const location = useLocation();
import {useStoryBookFilesByCategory} from './storySidebar';
import type {StoryTreeNode} from './storyTree';
import {type StoryDescriptor} from './useStoriesLoader';
import {useStory} from './useStory';

export function StoryFooter() {
const {story} = useStory();
const categories = useStoryBookFilesByCategory();
const pagination = findPreviousAndNextStory(story, categories);

const prevLocationDescriptor = qs.stringify({
...location.query,
name: pagination?.prev?.story.filesystemPath,
});
const nextLocationDescriptor = qs.stringify({
...location.query,
name: pagination?.next?.story.filesystemPath,
});
const stories = useStoryBookFilesByCategory();
const pagination = findPreviousAndNextStory(story, stories);

return (
<Flex align="center" justify="space-between" gap={space(2)}>
{pagination?.prev && (
<Card
to={`/stories/?${prevLocationDescriptor}`}
icon={<IconArrow direction="left" />}
>
<Card to={pagination.prev.location} icon={<IconArrow direction="left" />}>
<CardLabel>Previous</CardLabel>
<CardTitle>{pagination.prev.story.label}</CardTitle>
<CardTitle>{pagination.prev.label}</CardTitle>
</Card>
)}
{pagination?.next && (
<Card
data-flip
to={`/stories/?${nextLocationDescriptor}`}
to={pagination.next.location}
icon={<IconArrow direction="right" />}
>
<CardLabel>Next</CardLabel>
<CardTitle>{pagination.next.story.label}</CardTitle>
<CardTitle>{pagination.next.label}</CardTitle>
</Card>
)}
</Flex>
Expand All @@ -56,14 +41,11 @@ function findPreviousAndNextStory(
story: StoryDescriptor,
categories: ReturnType<typeof useStoryBookFilesByCategory>
): {
next: {category: string; story: StoryTreeNode} | undefined;
prev: {category: string; story: StoryTreeNode} | undefined;
next?: StoryTreeNode;
prev?: StoryTreeNode;
} | null {
const stories = Object.entries(categories).flatMap(([key, category]) =>
category.map(s => ({category: key, story: s}))
);

const currentIndex = stories.findIndex(s => s.story.filesystemPath === story.filename);
const stories = Object.values(categories).flat();
const currentIndex = stories.findIndex(s => s.filesystemPath === story.filename);

if (currentIndex === -1) {
return null;
Expand Down
Loading