Skip to content

feat(feedback): enable feedback category option for org stats page #94649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2025
Merged

feat(feedback): enable feedback category option for org stats page #94649

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23c90f8
feat(feedback): enable feedback category option for org stats page
aliu39 Jun 30, 2025
b91f2a5
Rename exact to feedback
aliu39 Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions static/app/constants/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,21 @@ export const DATA_CATEGORY_INFO = {
showExternalStats: true,
},
},
[DataCategoryExact.USER_REPORT_V2]: {
name: DataCategoryExact.USER_REPORT_V2,
apiName: 'feedback',
plural: DataCategory.USER_REPORT_V2,
displayName: 'user feedback',
titleName: t('User Feedback'),
productName: t('User Feedback'),
uid: 14,
isBilledCategory: false,
docsUrl: 'https://docs.sentry.io/product/user-feedback/',
statsInfo: {
...DEFAULT_STATS_INFO,
showExternalStats: true,
},
},
[DataCategoryExact.TRANSACTION_PROCESSED]: {
name: DataCategoryExact.TRANSACTION_PROCESSED,
apiName: 'transactions',
Expand Down
2 changes: 2 additions & 0 deletions static/app/types/core.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ export enum DataCategory {
LOG_BYTE = 'logBytes',
SEER_AUTOFIX = 'seerAutofix',
SEER_SCANNER = 'seerScanner',
USER_REPORT_V2 = 'feedback',
}

/**
Expand Down Expand Up @@ -123,6 +124,7 @@ export enum DataCategoryExact {
LOG_BYTE = 'logByte',
SEER_AUTOFIX = 'seerAutofix',
SEER_SCANNER = 'seerScanner',
USER_REPORT_V2 = 'user_report_v2',
Copy link
Member

@isabellaenriquez isabellaenriquez Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be in the same format as the others (camel case singular). Does changing this to that format break stats?

Copy link
Member Author

@aliu39 aliu39 Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I thought from the comment that it's supposed to match the relay enum?

Copy link
Member Author

@aliu39 aliu39 Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/getsentry/relay/blob/e4ba401fba6028036f251685d77b7263e61310d3/relay-base-schema/src/data_category.rs#L153-L154

Copy link
Member

@isabellaenriquez isabellaenriquez Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh i totally missed that, then that means all the others in camel case need to be changed 😭 not your problem though, thanks for pointing out

Copy link
Member Author

@aliu39 aliu39 Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha thanks, think it should be feedback actually based on https://github.com/getsentry/relay/blob/e4ba401fba6028036f251685d77b7263e61310d3/relay-base-schema/src/data_category.rs#L192

}

export interface DataCategoryInfo {
Expand Down
Loading