Skip to content

Conversation

@chromy
Copy link
Contributor

@chromy chromy commented May 20, 2025

We're investigating analyzing and distributing pre-production artifacts
(e.g. .apk, .ipa, .aab, .xcframework, etc). This adds a directory for that code
to live in so it is not spread across the codebase as well as matching CODEOWNERS
entry for the team investigating this.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 20, 2025
@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2083 at 1:157339 in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #91961      +/-   ##
==========================================
- Coverage   87.63%   87.63%   -0.01%     
==========================================
  Files       10361    10361              
  Lines      587521   587521              
  Branches    22594    22594              
==========================================
- Hits       514860   514849      -11     
- Misses      72240    72251      +11     
  Partials      421      421              

@chromy chromy changed the title Add directory for work on artifacts Add directory for artifacts May 20, 2025
@chromy chromy force-pushed the chromy/2025-05-20-add-dir branch from 8c82b6d to 2151033 Compare May 20, 2025 21:10
@chromy chromy marked this pull request as ready for review May 20, 2025 21:23
@chromy chromy requested a review from a team as a code owner May 20, 2025 21:23
@asottile-sentry
Copy link
Contributor

just a thought -- would it make sense to write this new thing as a separate service rather than having to work in the monolith?

it's also a bit strange to introduce just an empty module

@chromy chromy force-pushed the chromy/2025-05-20-add-dir branch from 2151033 to 6dbed0b Compare May 20, 2025 23:07
@chromy chromy changed the title Add directory for artifacts Add directory for preprod May 20, 2025
@chromy
Copy link
Contributor Author

chromy commented May 20, 2025

just a thought -- would it make sense to write this new thing as a separate service rather than having to work in the monolith?

Not sure! I need to learn more about serivces.
@JoshFerge suggested in the offline discussion was that sticking with the monolith might be best for now.

it's also a bit strange to introduce just an empty module

Sorry! Will fill it out shortly - but happy to have spurred these useful discussions!

@chromy chromy force-pushed the chromy/2025-05-20-add-dir branch from 6dbed0b to 1cfedd7 Compare May 21, 2025 10:36
@chromy chromy merged commit 620452a into master May 21, 2025
60 checks passed
@chromy chromy deleted the chromy/2025-05-20-add-dir branch May 21, 2025 11:12
@cmanallen
Copy link
Member

Retro-approving my offline approval (for posterity). This will be a good place for your team to get started!

andrewshie-sentry pushed a commit that referenced this pull request Jun 2, 2025
We're investigating analyzing and distributing pre-production artifacts
(e.g. .apk, .ipa, .aab, .xcframework, etc). This adds a directory for
that code to live in so it is not spread across the codebase as well as
matching CODEOWNERS entry for the team investigating this.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants