Skip to content

styles(explore): Reorganization explore for tours #89616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

styles(explore): Reorganization explore for tours #89616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 55 additions & 53 deletions static/app/views/explore/spans/spansTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,41 +236,40 @@ export function SpansTabContentImpl({

return (
<SearchQueryBuilderProvider {...eapSpanSearchQueryProviderProps}>
<Body
withToolbar={expanded}
withHints={organization.features.includes('traces-schema-hints')}
>
<Body withToolbar={expanded}>
<TopSection>
<StyledPageFilterBar condensed>
<ProjectPageFilter />
<EnvironmentPageFilter />
<DatePageFilter
defaultPeriod={defaultPeriod}
maxPickableDays={maxPickableDays}
relativeOptions={({arbitraryOptions}) => ({
...arbitraryOptions,
...relativeOptions,
})}
/>
</StyledPageFilterBar>
<EAPSpanSearchQueryBuilder {...eapSpanSearchQueryBuilderProps} />
<FilterSection>
<StyledPageFilterBar condensed>
<ProjectPageFilter />
<EnvironmentPageFilter />
<DatePageFilter
defaultPeriod={defaultPeriod}
maxPickableDays={maxPickableDays}
relativeOptions={({arbitraryOptions}) => ({
...arbitraryOptions,
...relativeOptions,
})}
/>
</StyledPageFilterBar>
<EAPSpanSearchQueryBuilder {...eapSpanSearchQueryBuilderProps} />
</FilterSection>
<Feature features="organizations:traces-schema-hints">
<SchemaHintsSection>
<SchemaHintsList
supportedAggregates={
mode === Mode.SAMPLES ? [] : ALLOWED_EXPLORE_VISUALIZE_AGGREGATES
}
numberTags={numberTags}
stringTags={stringTags}
isLoading={numberTagsLoading || stringTagsLoading}
exploreQuery={query}
source={SchemaHintsSources.EXPLORE}
tableColumns={fields}
setPageParams={setExplorePageParams}
/>
</SchemaHintsSection>
</Feature>
</TopSection>
<Feature features="organizations:traces-schema-hints">
<SchemaHintsSection>
<SchemaHintsList
supportedAggregates={
mode === Mode.SAMPLES ? [] : ALLOWED_EXPLORE_VISUALIZE_AGGREGATES
}
numberTags={numberTags}
stringTags={stringTags}
isLoading={numberTagsLoading || stringTagsLoading}
exploreQuery={query}
source={SchemaHintsSources.EXPLORE}
tableColumns={fields}
setPageParams={setExplorePageParams}
/>
</SchemaHintsSection>
</Feature>
<SideSection withToolbar={expanded}>
<ExploreToolbar width={300} extras={toolbarExtras} />
</SideSection>
Expand Down Expand Up @@ -336,18 +335,20 @@ function OnboardingContent(props: OnboardingContentProps) {
return (
<Layout.Body>
<TopSection>
<StyledPageFilterBar condensed>
<ProjectPageFilter />
<EnvironmentPageFilter />
<DatePageFilter
defaultPeriod={props.defaultPeriod}
maxPickableDays={props.maxPickableDays}
relativeOptions={({arbitraryOptions}) => ({
...arbitraryOptions,
...props.relativeOptions,
})}
/>
</StyledPageFilterBar>
<FilterSection>
<StyledPageFilterBar condensed>
<ProjectPageFilter />
<EnvironmentPageFilter />
<DatePageFilter
defaultPeriod={props.defaultPeriod}
maxPickableDays={props.maxPickableDays}
relativeOptions={({arbitraryOptions}) => ({
...arbitraryOptions,
...props.relativeOptions,
})}
/>
</StyledPageFilterBar>
</FilterSection>
</TopSection>
<OnboardingContentSection>
<Onboarding project={props.onboardingProject} organization={organization} />
Expand Down Expand Up @@ -383,32 +384,33 @@ function checkIsAllowedSelection(
return selectedMinutes <= maxPickableMinutes;
}

const Body = styled(Layout.Body)<{
withHints: boolean;
withToolbar: boolean;
}>`
const Body = styled(Layout.Body)<{withToolbar: boolean}>`
@media (min-width: ${p => p.theme.breakpoints.medium}) {
display: grid;
${p =>
p.withToolbar
? `grid-template-columns: 300px minmax(100px, auto);`
: `grid-template-columns: 0px minmax(100px, auto);`}
grid-template-rows: auto ${p => (p.withHints ? 'auto 1fr' : '1fr')};
grid-template-rows: auto 1fr;
align-content: start;
gap: ${space(2)} ${p => (p.withToolbar ? `${space(2)}` : '0px')};
transition: 700ms;
}
`;

const TopSection = styled('div')`
grid-column: 1/3;
display: flex;
flex-direction: column;
gap: ${space(2)};
`;

const FilterSection = styled('div')`
display: grid;
gap: ${space(2)};
grid-column: 1/3;
margin-bottom: ${space(2)};

@media (min-width: ${p => p.theme.breakpoints.medium}) {
grid-template-columns: minmax(300px, auto) 1fr;
margin-bottom: 0;
}
`;

Expand Down
Loading