fix(derive_code_mapping): Grab absPath instead of abs_path #88673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary for using the "Set up code mapping" modal for Java projects. Fixes [SENTRY-3RDY](https://sentry.sentry.io/issues/6505158896/)
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #88673 +/- ##
==========================================
- Coverage 87.74% 87.74% -0.01%
==========================================
Files 10014 10030 +16
Lines 567451 568036 +585
Branches 22296 22296
==========================================
+ Hits 497934 498429 +495
- Misses 69100 69190 +90
Partials 417 417 |
armenzg
added a commit
that referenced
this pull request
Apr 3, 2025
Now that we can derive code mappings for Java, we can make the modal pass the missing parameters to make it work. This requires the fix in #88673.
JoshFerge
approved these changes
Apr 3, 2025
adrian-codecov
pushed a commit
that referenced
this pull request
Apr 3, 2025
This is necessary for using the "Set up code mapping" modal for Java projects. Fixes [SENTRY-3RDY](https://sentry.sentry.io/issues/6505158896/)
armenzg
added a commit
that referenced
this pull request
Apr 4, 2025
Now that we can derive code mappings for Java, we can make the modal pass the missing parameters to make it work. This requires the fix in #88673.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
This is necessary for using the "Set up code mapping" modal for Java projects. Fixes [SENTRY-3RDY](https://sentry.sentry.io/issues/6505158896/)
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 8, 2025
Now that we can derive code mappings for Java, we can make the modal pass the missing parameters to make it work. This requires the fix in #88673.
armenzg
added this to the
Automate Code Mappings & In-App Stack Trace Rules for Java projects milestone
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for using the "Set up code mapping" modal for Java projects.
Fixes SENTRY-3RDY