Repository navigation
Conversation
Resolving issues from the issue list always showed "Unable to update issues" even when the API returned a 400 explaining why (for example, resolving in "Next Release" when the project has no release data). Surface the first validation message from the response, and keep the generic message for other failures. Refs getsentry#125011
cvxluo
reviewed
Oct 8, 2026
| }); | ||
| } | ||
|
|
||
| function findFirstErrorMessage(value: unknown): string | undefined { |
Contributor
There was a problem hiding this comment.
i think we have some variety of this function already elsewhere in the codebase, like getWorkflowEngineResponseErrorMessage
Contributor
Author
There was a problem hiding this comment.
Good catch, thanks. Replaced it with getWorkflowEngineResponseErrorMessage in ce83b3a.
…ate errors The bulk update error toast walked the response body with its own findFirstErrorMessage. getWorkflowEngineResponseErrorMessage already extracts the first message from a nested error response, so use it instead.
cvxluo
approved these changes
Oct 8, 2026
cvxluo
left a comment
Contributor
There was a problem hiding this comment.
lgtm, thanks for putting this up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolving issues from the issue list always shows the generic "Unable to update issues" toast, even when the API responds with a 400 that explains why. For example, resolving "in next release" on a project with no release data returns
{"statusDetails": {"inNextRelease": ["No release data present in the system to form a basis for 'Next Release'"]}}, and the user only sees the reason by opening the browser console.performBulkUpdatenow shows the first validation message from a 400 response (Unable to update issues: <message>). Other failures keep the existing generic message. The 400 body here is a nested serializer error rather than adetailstring, sogetRequestErrorUserMessagewould not have surfaced it.This only covers the issue list. The issue details page goes through
GroupStore.onUpdateError, which has its own generic message, and I left that alone to keep this PR focused.Tests added in
issueList/actions/index.spec.tsx: one for the validation message and one confirming the generic fallback. The validation test fails without the change.Fixes #125011
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.