Skip to content

Conversation

@jpnurmi
Copy link
Collaborator

@jpnurmi jpnurmi commented Jun 13, 2025

Q: Should it be called sentry_attach_buffer or sentry_attach_data?
A: sentry_attach_bytes

TODO:

@github-actions
Copy link

github-actions bot commented Jun 13, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 8775959

@supervacuus
Copy link
Collaborator

If we want to stay consistent with other SDKs, bytes is fine since we also use it for the UUID API in a similar manner. data is somewhat unspecific. We use data in the context of user_data for callbacks (but only as parameter specs) and data as the field for transactions and spans (as part of the function names).

@jpnurmi jpnurmi force-pushed the feat/attach-data-buffer branch from 90f233b to 9e3dd5e Compare June 17, 2025 07:44
@jpnurmi jpnurmi changed the title feat: Support attaching in-memory data buffers feat: support attaching bytes Jun 19, 2025
@jpnurmi jpnurmi marked this pull request as ready for review June 19, 2025 08:22
Copy link
Collaborator

@supervacuus supervacuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice, thanks! A couple of minor points and one thing that is probably just a limit of my imagination.

Copy link
Collaborator

@supervacuus supervacuus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if you'd still like to add anything, but from my end, this is ready to be released.

@jpnurmi
Copy link
Collaborator Author

jpnurmi commented Jun 24, 2025

I don't have anything else in mind regarding attachments. We should now have everything that was requested. Thanks for your time reviewing yet another big PR.

@jpnurmi jpnurmi merged commit 9dd7d6c into master Jun 24, 2025
55 of 58 checks passed
@jpnurmi jpnurmi deleted the feat/attach-data-buffer branch June 24, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants