-
-
Notifications
You must be signed in to change notification settings - Fork 199
feat: support attaching bytes #1275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
If we want to stay consistent with other SDKs, |
fc2a84c to
90f233b
Compare
90f233b to
9e3dd5e
Compare
> warning C4190: 'to_crashpad_attachment' has C-linkage specified, > but returns UDT 'crashpad::Attachment' which is incompatible with C
type & content_type are passed separately and content_type is cloned in sentry__attachments_add()
supervacuus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks nice, thanks! A couple of minor points and one thing that is probably just a limit of my imagination.
supervacuus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if you'd still like to add anything, but from my end, this is ready to be released.
|
I don't have anything else in mind regarding attachments. We should now have everything that was requested. Thanks for your time reviewing yet another big PR. |
Q: Should it be calledsentry_attach_bufferorsentry_attach_data?A:
sentry_attach_bytesTODO:
Crashpad: IPCfeat: support attaching bytes on Windows and Linux crashpad#127(write files instead due to IPC limits)