Skip to content

feat: allow PS SDK to implement custom transport #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
supervacuus merged 2 commits into from
Jun 4, 2025
Merged

feat: allow PS SDK to implement custom transport #1262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f186290
feat: allow downstream SDKs to implement custom transport
vaind Jun 2, 2025
ef4e270
add "pshttp" support to the list of supported ones
vaind Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ if(CMAKE_SYSTEM_NAME STREQUAL "Linux")
set(LINUX TRUE)
elseif(CMAKE_SYSTEM_NAME STREQUAL "AIX" OR CMAKE_SYSTEM_NAME STREQUAL "OS400")
set(AIX TRUE)
elseif(CMAKE_SYSTEM_NAME STREQUAL "Prospero")
set(PROSPERO TRUE)
endif()

#setup sentry library type
Expand Down Expand Up @@ -117,28 +119,39 @@ endif()

if(WIN32)
set(SENTRY_DEFAULT_TRANSPORT "winhttp")
set(_SUPPORTED_TRANSPORTS "none, winhttp")
elseif(PROSPERO)
set(SENTRY_DEFAULT_TRANSPORT "pshttp")
set(_SUPPORTED_TRANSPORTS "none, pshttp")
elseif((APPLE AND NOT IOS) OR LINUX OR AIX OR NX)
set(SENTRY_DEFAULT_TRANSPORT "curl")
set(_SUPPORTED_TRANSPORTS "none, curl")
else()
set(SENTRY_DEFAULT_TRANSPORT "none")
set(_SUPPORTED_TRANSPORTS "none, curl, or winhttp on Windows")
endif()

set(SENTRY_TRANSPORT ${SENTRY_DEFAULT_TRANSPORT} CACHE STRING
"The HTTP transport that sentry uses to submit events to the sentry server, can be either 'none', 'curl' or 'winhttp' on windows.")
"The HTTP transport that sentry uses to submit events to the sentry server, can be one of: ${_SUPPORTED_TRANSPORTS}.")

if(SENTRY_TRANSPORT STREQUAL "winhttp")
set(SENTRY_TRANSPORT_WINHTTP TRUE)
if(NOT WIN32)
message(FATAL_ERROR "The winhttp transport is only supported on Windows.")
endif()
elseif(SENTRY_TRANSPORT STREQUAL "curl")
set(SENTRY_TRANSPORT_CURL TRUE)
elseif(SENTRY_TRANSPORT STREQUAL "none")
set(SENTRY_TRANSPORT_NONE TRUE)
elseif(SENTRY_TRANSPORT STREQUAL "pshttp")
# Not implemented here, but in the downstream SDK
if(NOT PROSPERO)
message(FATAL_ERROR "The pshttp transport is only supported on PlayStation.")
endif()
else()
message(FATAL_ERROR "SENTRY_TRANSPORT must be one of 'none', 'curl' or 'winhttp'")
message(FATAL_ERROR "SENTRY_TRANSPORT must be one of: ${_SUPPORTED_TRANSPORTS}")
endif()

if(SENTRY_TRANSPORT_WINHTTP AND NOT WIN32)
message(FATAL_ERROR "The winhttp transport is only supported on Windows.")
endif()

if(SENTRY_BUILD_TESTS OR SENTRY_BUILD_EXAMPLES)
enable_testing()
Expand Down
2 changes: 1 addition & 1 deletion src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ if(WIN32)
path/sentry_path_windows.c
symbolizer/sentry_symbolizer_windows.c
)
elseif(NX OR CMAKE_SYSTEM_NAME STREQUAL "Prospero")
elseif(NX OR PROSPERO)
sentry_target_sources_cwd(sentry
sentry_unix_spinlock.h
path/sentry_path_unix.c
Expand Down
Loading