API Change / Addition to sentry_capture_minidump

[zsd4yr]

See #1135

[supervacuus]

Please add a changelog entry using the header ##Unreleased if it is not there yet. Then, add a section **Breaking changes**: to list the changes.

[codecov]

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.79%. Comparing base (03143a8) to head (f870493).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1138      +/-   ##
==========================================
+ Coverage   82.66%   82.79%   +0.12%     
==========================================
  Files          53       53              
  Lines        7927     7939      +12     
  Branches     1239     1239              
==========================================
+ Hits         6553     6573      +20     
+ Misses       1263     1256       -7     
+ Partials      111      110       -1     

[zsd4yr]

Looking into this failure in tests

FAILED tests/test_unit.py::test_unit[capture_minidump_basic] - subprocess.CalledProcessError: Command '['/Users/runner/Library/Android/sdk/platform-tools/adb', 'shell', 'cd /data/local/tmp && LD_LIBRARY_PATH=. ./sentry_test_unit --no-summary capture_minidump_basic; echo -n ret:$?']' returned non-zero exit status 1.

[zsd4yr]

And these

FAILED tests/test_integration_http.py::test_capture_minidump - Failed: running command failed: valgrind --suppressions=/home/runner/work/sentry-native/sentry-native/tests/valgrind.txt --error-exitcode=33 --leak-check=yes ./sentry_example log attachment capture-minidump
FAILED tests/test_unit.py::test_unit[capture_minidump_basic] - Failed: running command failed: valgrind --suppressions=/home/runner/work/sentry-native/sentry-native/tests/valgrind.txt --error-exitcode=33 --leak-check=yes ./sentry_test_unit --no-summary capture_minidump_basic
FAILED tests/test_unit.py::test_unit[capture_minidump_without_sentry_init] - Failed: running command failed: valgrind --suppressions=/home/runner/work/sentry-native/sentry-native/tests/valgrind.txt --error-exitcode=33 --leak-check=yes ./sentry_test_unit --no-summary capture_minidump_without_sentry_init
FAILED tests/test_unit.py::test_unit_transport[capture_minidump_basic] - Failed: running command failed: valgrind --suppressions=/home/runner/work/sentry-native/sentry-native/tests/valgrind.txt --error-exitcode=33 --leak-check=yes ./sentry_test_unit --no-summary capture_minidump_basic
FAILED tests/test_unit.py::test_unit_transport[capture_minidump_without_sentry_init] - Failed: running command failed: valgrind --suppressions=/home/runner/work/sentry-native/sentry-native/tests/valgrind.txt --error-exitcode=33 --leak-check=yes ./sentry_test_unit --no-summary capture_minidump_without_sentry_init

[supervacuus]

Looking into this failure in tests

There is no need, @zsd4yr. I had to rewrite the proposed implementation (and parts of the initial implementation). I'll take over from here. Thanks!

[zsd4yr]

Thanks @supervacuus !

[zsd4yr]

@supervacuus Thanks for getting this across the finish line! When will the next drop be available? I'll update our fork with this :)