Skip to content

fix(nuxt): Added top-level fallback exports #18083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2025
Merged

fix(nuxt): Added top-level fallback exports #18083

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66817b6
fix(nuxt): added root fallback exports
logaretm Nov 3, 2025
f1a2a6d
fix: added require just for completeness sake
logaretm Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/nuxt/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@
"node": {
"import": "./build/esm/index.server.js",
"require": "./build/cjs/index.server.js"
}
},
"import": "./build/esm/index.server.js"
Copy link

@cursor cursor bot Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incomplete fallback handling for module resolution

Missing "require" fallback alongside the "import" fallback. Both "browser" and "node" conditions provide both "import" and "require" options, but the top-level fallback only provides "import". This means tools or environments that don't match "browser" or "node" conditions and attempt to use CommonJS (require) will fail to resolve the package, even though the intent is to provide a fallback for such cases. Consider adding "require": "./build/cjs/index.server.js" after the "import" fallback for consistency and completeness.

Fix in Cursor Fix in Web

Copy link
Collaborator Author

@logaretm logaretm Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my tests, it doesn't seem like we need it but I will add it.

},
"./module": {
"types": "./build/module/types.d.ts",
Expand Down
Loading