feat(core): Increase default transport buffer size from 30 to 64 #11764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nowadays, the SDK simply sends more data and we are seeing overflows in our E2E tests which do not produce an unreasonable amount of events. Dropped events can lead to broken traces and confusing data inside Sentry, which is why I think bumping this is reasonable. We make this under the assumption that an event in the transport holds at max something like 5MB of memory, which would bump the memory consumption from 150MB to 320MB.
mydea
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nowadays, the SDK simply sends more data and we are seeing overflows in our E2E tests which do not produce an unreasonable amount of events.
Dropped events can lead to broken traces and confusing data inside Sentry, which is why I think bumping this is reasonable.
We make this under the assumption that an event in the transport holds at max something like 5MB of memory, which would bump the memory consumption from 150MB to 320MB.