fix: Use magic-string appendLeft instead of replace#303
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /^(?:\s*|\/\*(?:.|\r|\n)*\*\/|\/\/.*[\n\r])*(?:"[^"]*";|'[^']*';)?/; | ||
|
|
||
| if (code.match(commentUseStrictRegex)?.[0]) { | ||
| const match = code.match(commentUseStrictRegex)?.[0]; |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
AbhiPrasad
approved these changes
Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an experimental fix that might resolve #298
I tried a bunch of things with our RegExp to understand whether it is wrong but couldn't reproduce the examined outcome.
This led me to believe that there is something going on inside the
magic-stringlibrary that might cause the issue. This is an experimental fix that should be equivalent in behaviour but will hopefully resolve the issue.