fix(esbuild): Inject different debug IDs into different output bundles#301
Merged
Conversation
mydea
reviewed
Jun 6, 2023
| contents: ` | ||
| import "_sentry-debug-id-injection-stub"; | ||
| import * as OriginalModule from "${originalPath}"; | ||
| export default OriginalModule.default; |
Member
There was a problem hiding this comment.
just sanity checking, does this also work if the original module has no default export?
Author
There was a problem hiding this comment.
Yes, I made sure to check this. The output code will look as follows in these situations:
var d = typeof window < "u" ? window : typeof global < "u" ? global : typeof self < "u" ? self : {};
d.SENTRY_RELEASE = { id: "0cd3502" };
(function () {
try {
var e =
typeof window < "u" ? window : typeof global < "u" ? global : typeof self < "u" ? self : {},
n = new Error().stack;
n &&
((e._sentryDebugIds = e._sentryDebugIds || {}),
(e._sentryDebugIds[n] = "e426cce9-c1fa-4eea-aa91-50e49ab0f23d"),
(e._sentryDebugIdIdentifier = "sentry-dbid-e426cce9-c1fa-4eea-aa91-50e49ab0f23d"));
} catch {}
})();
function o() {
return global.SENTRY_RELEASE;
}
function t() {
console.log("Hello world!");
}
console.log("entrypoint1.js loaded");
function p() {
console.log("called main (entrypoint1.js)"), t();
}
console.log("global:", o());
var w = void 0;
export { w as default, o as getGlobal, p as main };
//# sourceMappingURL=entrypoint1.js.map
mydea
approved these changes
Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #300
Esbuild will generate one output bundle for each entrypoint that is defined. The issue previously was that we were injecting an import that is only resolved and loaded once for all entrypoints, leading to the same debug ID in all output bundles.
We attempt fixing this by transforming the entrypoints via a proxy module that in return imports a stub that injects the debug ID snippets into the entrypoints.
One thing I am still a little bit unsure about is why just adding a namespace to the existingonResolveandonLoaddidn't work, since that is basically what we're doing here, minus the proxy module. It fails because it can't the injected file anymore. Maybe this is some intransparent behaviour of esbuild.It seems esbuild does not call
onResolveforinjected modules.