ref(core): Extract release injection into separate plugins#218
Merged
Conversation
Closed
lforst
force-pushed
the
lforst-extract-release-injection
branch
from
c04eb3e to
5388844
Compare
added 2 commits
April 30, 2023 19:18
added 10 commits
May 2, 2023 14:22
…xtract-release-injection
…xtract-release-injection
…xtract-release-injection
Author
|
This is unfortunately a bigger one :( |
AbhiPrasad
approved these changes
May 2, 2023
AbhiPrasad
left a comment
AbhiPrasad
left a comment
Contributor
There was a problem hiding this comment.
in the end its always dependency injection
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the release injection logic into individual bundler-specific plugins.
Why?
Release injection messes with module/bundle code and is quite finnicky to get working with all bundlers. Unplugin doesn't seem to help in a lot of cases and even introduces additional bugs with source maps.
Cool side fact: With this change we will always be injecting at the top of modules/bundles, meaning the release value will always be available. This has not been the case for the Sentry webpack plugin so far.