feat(core): Import release injection code from each module#188
Merged
Conversation
lforst
commented
Mar 29, 2023
Comment on lines
-15
to
-20
| "exports": { | ||
| ".": { | ||
| "import": "./dist/esm/index.mjs", | ||
| "require": "./dist/cjs/index.js" | ||
| } | ||
| }, |
Author
There was a problem hiding this comment.
This was causing weird problems when importing @sentry/bundler-plugin-core/sentry-release-injection-file. This standard is cursed.
Contributor
There was a problem hiding this comment.
It might be that with this you have to name it sentry-release-injection-file.mjs for esm.
AbhiPrasad
approved these changes
Mar 29, 2023
Comment on lines
-15
to
-20
| "exports": { | ||
| ".": { | ||
| "import": "./dist/esm/index.mjs", | ||
| "require": "./dist/cjs/index.js" | ||
| } | ||
| }, |
Contributor
There was a problem hiding this comment.
It might be that with this you have to name it sentry-release-injection-file.mjs for esm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #182
Fixes #180
This somewhat reverts to an old behavior where we inject the release injector code into each module. The difference this time is that we reference a file that actually exists in our package instead of a virtual file. This should circumvent the situation we ran into in #163 because the release injector module will now always exist.