feat: Replace entries option with releaseInjectionTargets#123
Merged
Conversation
lforst
changed the title
entries option with releaseInjectionTargets
lforst
force-pushed
the
lforst-yeet-is-entry-logic
branch
from
ee755ee to
1c727a5
Compare
Lms24
approved these changes
Nov 16, 2022
lforst
force-pushed
the
lforst-yeet-is-entry-logic
branch
from
57d0e1b to
02636cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We faced problems when dogfooding the bundler plugin in https://github.com/getsentry/gib-potato.
We tried to inject the release in non-JS files.
.js,.ts,.jsx,.tsx,.cjsor.mjs).Considering the above fixed, if an app's entry point was a non-JS file (e.g. a
.htmlfile) we didn't inject the release anywhere at all.entriesoption with a newreleaseInjectionTargetsoption to allow for more fine-grained control in overriding in which modules the release code should be injected. This is a breaking change so we added an entry in the migration docs.