chore(deps): update Cocoa SDK to v9.4.0#456
Open
github-actions[bot] wants to merge 1 commit intomainfrom
Open
Conversation
8320538 to
d06fe80
Compare
3bbbea5 to
d4be44f
Compare
01d6fb9 to
5e19f71
Compare
5e19f71 to
665d9b3
Compare
665d9b3 to
d573ad2
Compare
d573ad2 to
cf2a786
Compare
cf2a786 to
68d1559
Compare
Contributor
Author
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Internal Changes 🔧
Other
🤖 This preview updates automatically when you update the PR. |
68d1559 to
d564877
Compare
d564877 to
39d30b4
Compare
| @@ -1,2 +1,2 @@ | |||
| version=8.57.3 | |||
| version=9.2.0 | |||
| repo=https://github.com/getsentry/sentry-cocoa | |||
There was a problem hiding this comment.
Bug: The code uses options.experimental.enableLogs, a property removed in Sentry Cocoa SDK v9.0.0. This will cause a crash with the updated dependency.
Severity: HIGH
Suggested Fix
In src/sentry/cocoa/cocoa_sdk.mm, change the line options.experimental.enableLogs = SentryOptions::get_singleton()->get_enable_logs(); to options.enableLogs = SentryOptions::get_singleton()->get_enable_logs(); to use the correct API for the updated SDK version.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: modules/sentry-cocoa.properties#L2
Potential issue: The pull request updates the Sentry Cocoa SDK to v9.2.0, which contains
a breaking change introduced in v9.0.0. The property `options.experimental.enableLogs`,
used in `src/sentry/cocoa/cocoa_sdk.mm`, was removed and replaced with
`options.enableLogs`. Attempting to access the old property path on the updated SDK will
cause a runtime crash during initialization on iOS and macOS platforms, as the property
no longer exists.
Did we get this right? 👍 / 👎 to inform future reviews.
39d30b4 to
e36855e
Compare
b6c9c39 to
9b846fd
Compare
9b846fd to
6b877b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps modules/sentry-cocoa.properties from 8.57.3 to 9.4.0.
Auto-generated by a dependency updater.