Repository navigation
ref: remove Android assembly store v4 support (never shipped) - #5750
Merged
Merged
Conversation
The v4 format only existed in .NET 11 previews and was reverted to v3 before GA (dotnet/android#12780). .NET 11 GA CoreCLR stores are v3 with 32-bit name hashes, which the header-derived index entry sizing already handles. Closes #5608 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## version7 #5750 +/- ##
============================================
+ Coverage 75.60% 75.98% +0.37%
============================================
Files 522 527 +5
Lines 19042 19255 +213
Branches 3679 3725 +46
============================================
+ Hits 14396 14630 +234
+ Misses 3810 3770 -40
- Partials 836 855 +19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ric-oliv
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes support for reading Android assembly store v4, which only existed in .NET 11 previews and was reverted to v3 before GA by dotnet/android#12780.
StoreReader: drops the v4 version constants, theirsupportedVersionsentries,ASSEMBLY_STORE_FORMAT_NUMBER_MASKand the conditionalcontent_idread.Header.NativeSizeis aconstagain, matching upstream.ATTRIBUTION.txtkeep the f1aecf9 sync point only for the header-derived index entry sizing (feat: Support reading .NET 11 Android assembly stores #5577), which is what .NET 11 GA CoreCLR stores (v3, 32-bit name hashes) still rely on.Create_SupportedVersion_ReadsStorecases are gone,Create_InvalidIndexSize_Throwsbuilds a v3 header, and v4 is now asserted unsupported.The prerequisite from the issue is met:
version7'sglobal.jsonis on 11.0.100-rc.2, and the non-AOTnet11.0APK/AAB tests inAndroidAssemblyReaderTestspass against the real stores it produces.Closes #5608
🤖 Generated with Claude Code