Skip to content

ref: remove Android assembly store v4 support (never shipped) - #5750

Merged
ric-oliv merged 2 commits into
version7from
ref/remove-assembly-store-v4
Oct 21, 2026
Merged

ric-oliv merged 2 commits into
version7from
ref/remove-assembly-store-v4

Conversation

@jamescrosswell

Copy link
Copy Markdown
Collaborator

Removes support for reading Android assembly store v4, which only existed in .NET 11 previews and was reverted to v3 before GA by dotnet/android#12780.

  • StoreReader: drops the v4 version constants, their supportedVersions entries, ASSEMBLY_STORE_FORMAT_NUMBER_MASK and the conditional content_id read. Header.NativeSize is a const again, matching upstream.
  • Header comments and ATTRIBUTION.txt keep the f1aecf9 sync point only for the header-derived index entry sizing (feat: Support reading .NET 11 Android assembly stores #5577), which is what .NET 11 GA CoreCLR stores (v3, 32-bit name hashes) still rely on.
  • Tests: the v4 Create_SupportedVersion_ReadsStore cases are gone, Create_InvalidIndexSize_Throws builds a v3 header, and v4 is now asserted unsupported.

The prerequisite from the issue is met: version7's global.json is on 11.0.100-rc.2, and the non-AOT net11.0 APK/AAB tests in AndroidAssemblyReaderTests pass against the real stores it produces.

Closes #5608

🤖 Generated with Claude Code

The v4 format only existed in .NET 11 previews and was reverted to v3
before GA (dotnet/android#12780). .NET 11 GA CoreCLR stores are v3 with
32-bit name hashes, which the header-derived index entry sizing already
handles.

Closes #5608

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jamescrosswell jamescrosswell linked an issue Oct 20, 2026 that may be closed by this pull request
@jamescrosswell jamescrosswell added the skip-changelog Suppress automatic changelog generation via Craft label Oct 20, 2026
@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.98%. Comparing base (1ce152c) to head (8c7537d).
⚠️ Report is 8 commits behind head on version7.

Additional details and impacted files
@@             Coverage Diff              @@
##           version7    #5750      +/-   ##
============================================
+ Coverage     75.60%   75.98%   +0.37%     
============================================
  Files           522      527       +5     
  Lines         19042    19255     +213     
  Branches       3679     3725      +46     
============================================
+ Hits          14396    14630     +234     
+ Misses         3810     3770      -40     
- Partials        836      855      +19     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jamescrosswell
jamescrosswell marked this pull request as ready for review October 20, 2026 22:04
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Oct 20, 2026
@ric-oliv
ric-oliv merged commit 7bafaa8 into version7 Oct 21, 2026
40 checks passed
@ric-oliv
ric-oliv deleted the ref/remove-assembly-store-v4 branch October 21, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium skip-changelog Suppress automatic changelog generation via Craft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ref: Remove Android assembly store v4 support (never shipped)

2 participants