Repository navigation
feat(quartz): Add an option to monitor all scheduled jobs - #5741
Merged
Merged
Conversation
… dependencies and streamlining SentryCronJobListener options handling
…and update Quartz integration
… collection parameter and streamlining option configuration
…dSentryScope method, update SentryMetricsMiddleware to support configurable options
The format-code workflow can't push its auto-fix to a fork branch, so it fails the check instead. Applying the fix here. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Every package needs a name/packageUrl/mainDocsUrl entry so craft can create its registry entry on first publish; a missing `name` fails the whole registry target rather than just that package. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Nov 12, 2026
XAN9xXx
pushed a commit
to XAN9xXx/sentry-dotnet
that referenced
this pull request
Nov 15, 2026
getsentry#5741 added these options to SentryQuartzOptions, and getsentry#5668 added Sentry.Quartz3 (which compiles the same source) with snapshots that predate them. Each PR was green on its own; together they broke main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a series adding automatic Crons monitoring for the most-used job schedulers in each SDK. Check-ins for a monitor that doesn't exist yet are dropped, so today each monitor has to be created by hand with its schedule copied from the code. Sending the job's schedule as the monitor config lets Sentry create the monitor and keep it in sync.
This adds
SentryQuartzOptions.MonitorAllJobs, which monitors every scheduled job without adding[SentryMonitorSlug]to each job class, andExcludedJobsto skip some by name, full key or regex. The monitor slug comes from the job key. Jobs with[SentryMonitorSlug]keep their own settings. Off by default.Only runs fired by a trigger whose schedule Sentry can represent are monitored, so one-off runs like
TriggerJob, triggers with a calendar and cron expressions Sentry can't express are skipped, as in sentry-python. Jobs with several triggers on different schedules, or that share a monitor slug with a job on a different schedule, are skipped too, since their monitor config can't be built.Stacked on #5505, through the
danf/quartz-5505-rebasedbranch since that PR's head is on a fork.