Skip to content

chore(deps): raise the OpenTelemetry floor to 1.12.0 - #5588

Merged
jamescrosswell merged 2 commits into
mainfrom
backport/otel-floor-1.12.0
Sep 20, 2026
Merged

jamescrosswell merged 2 commits into
mainfrom
backport/otel-floor-1.12.0

Conversation

@jamescrosswell

Copy link
Copy Markdown
Collaborator

Closes #4931

Summary

Backports #5560 from version7 to main (6.x), and allowlists the remaining OpenTelemetry advisory so the nightly List vulnerable packages job goes green again.

Project Package Before After
Sentry.OpenTelemetry OpenTelemetry 1.6.0 1.12.0
Sentry.OpenTelemetry.Exporter OpenTelemetry.Exporter.OpenTelemetryProtocol 1.10.0 1.12.0

The floor rationale is unchanged from #5560: OpenTelemetry.Api 1.10.0–1.11.1 are delisted from nuget.org over GHSA-8785-wc3w-h8q6, a CPU DoS triggered just by receiving traceparent/tracestate headers, and 1.11.1/1.11.2 pull the deprecated Grpc.Core on net462. The cherry-pick applied cleanly.

Allowlist changes

  • Added GHSA-4625-4j76-fww9 (OpenTelemetry.Exporter.OpenTelemetryProtocol, fixed only in 1.15.3). Exploiting it requires the user to opt in to the experimental disk retry (OTEL_DOTNET_EXPERIMENTAL_OTLP_RETRY=disk) without setting a retry directory, and a local attacker with access to the shared temp directory. Sentry never enables disk retry, and setting the directory is a full workaround, so it doesn't justify forcing consumers up to 1.15.3.
  • Updated the reason for GHSA-g94r-2vxg-569j to reflect the new 1.12.0 floor, which now covers both packages.

🤖 Generated with Claude Code

jamescrosswell and others added 2 commits September 17, 2026 13:24
Sentry.OpenTelemetry floored OpenTelemetry at 1.6.0 and
Sentry.OpenTelemetry.Exporter floored OpenTelemetry.Exporter.OpenTelemetryProtocol
at 1.10.0. The latter resolved OpenTelemetry.Api 1.10.0 by default, which is
delisted from nuget.org over GHSA-8785-wc3w-h8q6 - a DoS triggered simply by
receiving a traceparent/tracestate header, with no opt-in. Nothing warned
consumers, because the exporter package itself is still listed.

1.12.0 rather than the 1.11.0 the issue asks for: 1.11.0 and 1.11.1 are delisted
too, and 1.11.1/1.11.2 pull the deprecated Grpc.Core on net462. 1.12.0 is the
lowest floor that is both listed and free of that. It also drops the
Google.Protobuf and Grpc.Net.Client dependencies the exporter carried at 1.10.0.

OpenTelemetry 1.12.0 no longer brings System.Net.Http in transitively on .NET
Framework, so Sentry.OpenTelemetry now references it explicitly, matching the
pattern already in Sentry.csproj.

Closes #4931

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
(cherry picked from commit 74e84fb)
The advisory needs opt-in experimental disk retry without a configured
directory, plus a local attacker, and is fixed only in 1.15.3. Also
refresh the GHSA-g94r-2vxg-569j reason for the new 1.12.0 floor.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@jamescrosswell jamescrosswell changed the title feat(otel): raise the OpenTelemetry floor to 1.12.0 feat(otel): bump the minimum supported version of OpenTelemetry to 1.12.0 Sep 17, 2026
@jamescrosswell jamescrosswell changed the title feat(otel): bump the minimum supported version of OpenTelemetry to 1.12.0 chore(deps): raise the OpenTelemetry floor to 1.12.0 Sep 17, 2026
@codecov

codecov Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.76%. Comparing base (cba98c9) to head (7e7755f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5588   +/-   ##
=======================================
  Coverage   74.76%   74.76%           
=======================================
  Files         515      515           
  Lines       18963    18963           
  Branches     3694     3694           
=======================================
  Hits        14177    14177           
  Misses       3908     3908           
  Partials      878      878           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jamescrosswell
jamescrosswell marked this pull request as ready for review September 17, 2026 04:34
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Sep 17, 2026
@jamescrosswell
jamescrosswell merged commit 7f470fa into main Sep 20, 2026
80 of 82 checks passed
@jamescrosswell
jamescrosswell deleted the backport/otel-floor-1.12.0 branch September 20, 2026 22:12
jamescrosswell added a commit to getsentry/sentry-docs that referenced this pull request Nov 11, 2026
> [!NOTE]
> This targets `dotnet-v7`, which collects the .NET docs for
sentry-dotnet 7.0.0. #20641 merges that branch into
`master` when 7.0.0 ships, so this PR can merge into `dotnet-v7` as soon
as it's approved.

## DESCRIBE YOUR PR

Updates the .NET OTLP page for sentry-dotnet 7.0.0. From 7.0.0,
`AddSentryOtlpExporter` no longer installs `SentryPropagator`, and the
`defaultTextMapPropagator` parameter is gone from it and from `UseOtlp`
(getsentry/sentry-dotnet#5319).

- Replaces the `SentryPropagator` bullet and the "Planned Removal" alert
with a Trace Propagation section. It covers what gets propagated by
default, how to add `SentryPropagator` for services that rely on
`sentry-trace`, and when `PropagateTraceparent` helps. A short note
covers the pre-7.0.0 behavior.
- Removes the `defaultTextMapPropagator` option.
- Raises the OpenTelemetry floor in Supported Versions to 1.12.0.
- Replaces the note saying not to set `TracesSampleRate` with a Sampling
section. With `UseOtlp()` the SDK creates no transactions, so
`TracesSampleRate` and `TracesSampler` are never read, and the OTLP
exporter installs no OpenTelemetry sampler. Sampling is configured on
the `TracerProvider`. This is true for 6.x as well.

Closes getsentry/sentry-dotnet#5546

### Notes for review

Where the page differs from the issue, it follows the source on
sentry-dotnet's `version7` branch:

- **`PropagateTraceparent` doesn't help the OTLP service itself.**
OpenTelemetry's default propagator (W3C trace context plus baggage,
which the OTel SDK installs) and the .NET runtime already send
`traceparent`. OTel's HttpClient instrumentation also overwrites any
`traceparent` that `SentryHttpMessageHandler` adds first. A local run
against a `version7` build sent identical headers with and without the
option. The page recommends it for the Sentry-traced services that call
the OTLP service, as `/concepts/otlp/sentry-with-otel/` already does.
- **`sentry-trace` doesn't disappear completely.** `UseOtlp()` stops
`SentryHttpMessageHandler` from creating spans, but its header
propagation still runs (`SentryMessageHandler.PropagateTraceHeaders`).
Sentry adds the handler to `IHttpClientFactory` clients when it's set up
through DI. Other requests only carry `sentry-trace` if the app
configures `SentryPropagator`.
- **The 1.12.0 floor already shipped in 6.11.1** (#5560 was backported
in getsentry/sentry-dotnet#5588), so that line is correct today and has
no "before 7.0.0" note.
- `SentryPropagator` is still public in `Sentry.OpenTelemetry.Exporter`
on `version7`, so the snippet doesn't need the deprecated
`Sentry.OpenTelemetry` package. It derives from `BaggagePropagator`,
which is why the composite doesn't list that one separately. The snippet
compiles against the `version7` build with OpenTelemetry 1.12.0.

## IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs
to go live.
Select exactly one option. For deadlines, replace `YYYY-MM-DD` with the
due date. You can update this information later by editing the PR
description.

- [x] Urgent deadline (GA date, etc.): 2026-11-30
- [ ] Other deadline: YYYY-MM-DD
- [ ] No deadline: Not urgent, can wait up to 1 week+

## SLA

- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
supplied a deadline.

Thanks in advance for your help!

## PRE-MERGE CHECKLIST

_Make sure you've checked the following before merging your changes:_

- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: ric-oliv <5938598+ric-oliv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump to >= 1.11.0 of the OpenTelemetry dependencies

2 participants