Add SentrySdk.SetTag #4228#4232
Merged
bruno-garcia merged 2 commits intogetsentry:mainfrom May 30, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4232 +/- ##
==========================================
- Coverage 75.73% 73.07% -2.66%
==========================================
Files 357 456 +99
Lines 13466 16529 +3063
Branches 2671 3286 +615
==========================================
+ Hits 10198 12079 +1881
- Misses 2593 3609 +1016
- Partials 675 841 +166 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bruno-garcia
approved these changes
May 30, 2025
Member
bruno-garcia
left a comment
There was a problem hiding this comment.
Perfect! Thank you so much for adding this
6 tasks
This was referenced Aug 18, 2025
This was referenced Sep 8, 2025
This was referenced Sep 15, 2025
This was referenced Oct 6, 2025
This was referenced Oct 20, 2025
This was referenced Nov 3, 2025
This was referenced Dec 8, 2025
This was referenced Dec 15, 2025
This was referenced Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also added
SentrySdk.UnsetTag, because it feels closely related withSetTag.Some questions I had while implementing this:
Hub.ConfigureScopewraps the call toScopeManager.ConfigureScopein a try/catch, would that be appropriate for these methods too? E.g.PushScopedoesn't use a try/catch.sentry-dotnet/src/Sentry/Internal/Hub.cs
Lines 90 to 100 in aebd6a2
IHasTagswhich can set multiple tags at once. Does it make sense to add it toSentrySdktoo?sentry-dotnet/src/Sentry/IHasTags.cs
Line 33 in aebd6a2