Skip to content

Conversation

@aritchie
Copy link
Contributor

@aritchie aritchie commented Apr 10, 2025

Resolves #2927

This is the initial implementation of proposed AOT build checks

Features

  • Generates a precompiled list of msbuild properties we were interested in based on various issues within our repo
  • Currently, we only look at PublishTrimmed and PublishAot in our AotHelper
  • Generates module initializer only on runnable targets
  • Ability to disable source generator if user encounters issue

TODO

  • Unit Tests
  • Document ability to disable source generator

@aritchie aritchie marked this pull request as ready for review April 25, 2025 15:08
@aritchie
Copy link
Contributor Author

Before we release this, I would like to do a beta test to ensure all of the nuget stuff has zero issues. CC: @jamescrosswell

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of stuff new to me so I don't have much to add, just a few suggestions

aritchie and others added 2 commits April 30, 2025 09:28
@jamescrosswell
Copy link
Collaborator

Before we release this, I would like to do a beta test to ensure all of the nuget stuff has zero issues. CC: @jamescrosswell

Makes sense. We can do a pre-release (like the 5.7.0 beta that we just made).

@aritchie aritchie merged commit 0514bfe into main May 7, 2025
26 checks passed
@aritchie aritchie deleted the 2927-aot_buildvars_sourcegen branch May 7, 2025 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate AotHelper properties at compile time

6 participants