Fix missing MAUI Shell navigation breadcrumbs on iOS

[albyrock87]

Fixes #3999

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.57%. Comparing base (495e742) to head (460e748).
Report is 509 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4006      +/-   ##
==========================================
+ Coverage   75.73%   76.57%   +0.84%     
==========================================
  Files         357      397      +40     
  Lines       13466    14517    +1051     
  Branches     2671     2929     +258     
==========================================
+ Hits        10198    11116     +918     
- Misses       2593     2685      +92     
- Partials      675      716      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jamescrosswell]

Thanks for the PR @albyrock87 ! This looks great ❤️

Can think of any way we could add automated tests for this? I'm thinking something like these... not sure how easy/feasible it is to test this particular case though.

The only other thing is we need a small description in the CHANGELOG.md file to explain to other users what has changed. In this case, I think the change is a Feature... some people might argue it's a Fix. I'm OK with either of those - it's all just how you squint at it.

[albyrock87]

@jamescrosswell I'm not able to compile the solution locally, but I've done my best to add a unit test which should pass and cover this PR entirely.

[aritchie]

@albyrock87 Looks like the git submodules didn't pull for you. I'll take a look and push this through. Thanks for all the help on this.

[bruno-garcia]

@jamescrosswell I'm not able to compile the solution locally, but I've done my best to add a unit test which should pass and cover this PR entirely.

could you try: git submodule update --init --recursive ?

[bruno-garcia]

@albyrock87 looks like CI is unhappy with:

Error: /home/runner/work/sentry-dotnet/sentry-dotnet/test/Sentry.Maui.Tests/MauiEventsBinderTests.Application.cs(154,9): error CS0618: 'Application.MainPage.set' is obsolete: 'This property is deprecated. Initialize your application by overriding Application.CreateWindow rather than setting MainPage. To modify the root page in an active application, use Windows[0].Page for applications with a single window. For applications with multiple windows, use Application.Windows to identify and update the root page on the correct window. Additionally, each element features a Window property, accessible when it's part of the current window.' [/home/runner/work/sentry-dotnet/sentry-dotnet/test/Sentry.Maui.Tests/Sentry.Maui.Tests.csproj::TargetFramework=net9.0]

If you could help with this bit so CI is OK we could merge the PR already it seems

[albyrock87]

@bruno-garcia I've:

• rebased PR onto main
• added changelog
• fixed unit test project build

git submodule update --init --recursive fixed the build, indeed, but now I see these two folders in my git changes, so I think those folders should be added to .gitignore.

[bruno-garcia]

git submodule update --init --recursive fixed the build, indeed, but now I see these two folders in my git changes, so I think those folders should be added to .gitignore.

The submodules don't need to go into .gitignore. It takes sometime to get used to working with it to be honest, yesterday I spent way too much time on that and I worked with these for years.

If you run git diff, does it show a change in commit sha? If so, you need to revert that.

If the diff shows a replaced sha and a new one one, copy the old one, go into the submodule director (which is essentially a different git repo) and git checkout old-sha. For example:

bruno@K29GRQ6W7J modules % git diff
diff --git a/modules/Ben.Demystifier b/modules/Ben.Demystifier
index 0a6b30f6..d7d639a6 160000
--- a/modules/Ben.Demystifier
+++ b/modules/Ben.Demystifier
@@ -1 +1 @@
-Subproject commit 0a6b30f6ac6892ff45b9dcd5b07d710e5228256e
+Subproject commit d7d639a60aada53e494b392a61c2eb6eeca379c2

Once you cd .. to get back to sentry-dotnet, if you do git status there won't be any diff anymore to correct.

Or simply:

git submodule update --init --recursive --checkout

[jamescrosswell]

So this PR is actually ready to merge.

The only thing stopping it now appears to be an issue with dotnet format, which may be related to this:

• dotnet format throws because it can't determine file encodings in 9.0.200 dotnet/sdk#46780 (comment)

I can't see how this would break in CI though as we're still using 9.0.100 in CI.

Additionally, when I use 9.0.201 locally I still have issues.

... the joys of fragile tooling 😞

[jamescrosswell]

Managed to get it over the line this time simply by running dotnet format from a windows machine. It looks like they broke something with LF line endings at some point. If this pops up again, one possible workaround might be to change the format workflow to run on Windows instead of macOS. Ideally this would get fixed however.

@albyrock87 big thank you for the PR - it's very much appreciated!