Added SubstringOrPatternMatcher#3566
Merged
jamescrosswell merged 9 commits intoversion-5.0.0from Sep 3, 2024
Merged
Conversation
…entry-dotnet into substring-or-pattern-matcher
Contributor
bitsandfoxes
left a comment
There was a problem hiding this comment.
We don't have anything on the samples using this?
Collaborator
Author
It would be used indirectly via various properties on the It's also used in the But nothing showing how people can define their own string or regex to assign to any of those options. |
bitsandfoxes
approved these changes
Sep 3, 2024
This was referenced Sep 8, 2025
This was referenced Sep 15, 2025
This was referenced Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3560
Summary
Previously we had a
SubstringOrRegexPatternclass that could store either a string or a regular expression and contained some logic to test either whether that string was a substring or whether the regular expression matched against some other target string.Instead we now have a
StringOrRegexclass that takes care of holding the string or regular expression, the ability to bind those values to configuration storage and provides various extensions.The logic to test that string or regex against a target has been refactored into a
SubstringOrPatternMatcherclass implementingIStringOrRegexMatcher.