Skip to content

Add node and browser sdk transport option docs - #5740

Merged
AbhiPrasad merged 4 commits into
masterfrom
abhi-transport-options
Nov 10, 2022
Merged

AbhiPrasad merged 4 commits into
masterfrom
abhi-transport-options

Conversation

@AbhiPrasad

@AbhiPrasad AbhiPrasad commented Nov 8, 2022 •

Copy link
Copy Markdown
Contributor

Only can get merged once getsentry/sentry-javascript#6161 is released.

Add documentation for Node Transport options.

@vercel

vercel Bot commented Nov 8, 2022 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sentry-docs ✅ Ready (Inspect) Visit Preview Nov 10, 2022 at 4:23PM (UTC)

@lizokm lizokm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonasBa JonasBa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AbhiPrasad

@AbhiPrasad AbhiPrasad self-assigned this Nov 10, 2022

@imatwawana imatwawana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some weirdness with the way the platformsection is working in the preview and left a question.


- `headers`: An object containing headers to be sent with every request.
- `proxy`: A proxy used for outbound requests. Can be http or https.
- `caCerts`: A single or list of a path to a file or directory, or a buffer of CA certificates

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit unclear. A single cert or a single path?

Suggested change
- `caCerts`: A single or list of a path to a file or directory, or a buffer of CA certificates
- `caCerts`: A single or list of a path to a file or directory, or a buffer of CA certificates

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can be:

  • a path to a CA certificate
  • a list of paths to a CA certificate
  • a buffer of CA certificates

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>

@imatwawana imatwawana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview looks good! I just made a small tweak, but otherwise LGTM!

Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
@AbhiPrasad
AbhiPrasad merged commit 23e6fa0 into master Nov 10, 2022
@AbhiPrasad
AbhiPrasad deleted the abhi-transport-options branch November 10, 2022 16:15
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 26, 2022

This branch was successfully deployed

1 active deployment
Preview — 8c539835 Deployed Nov 10, 2022 by vercel[bot]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants