Repository navigation
Add node and browser sdk transport option docs - #5740
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
imatwawana
reviewed
Nov 10, 2022
imatwawana
left a comment
Contributor
There was a problem hiding this comment.
Found some weirdness with the way the platformsection is working in the preview and left a question.
|
|
||
| - `headers`: An object containing headers to be sent with every request. | ||
| - `proxy`: A proxy used for outbound requests. Can be http or https. | ||
| - `caCerts`: A single or list of a path to a file or directory, or a buffer of CA certificates |
Contributor
There was a problem hiding this comment.
This is a bit unclear. A single cert or a single path?
Suggested change
| - `caCerts`: A single or list of a path to a file or directory, or a buffer of CA certificates | |
| - `caCerts`: A single or list of a path to a file or directory, or a buffer of CA certificates |
Contributor
Author
There was a problem hiding this comment.
it can be:
- a path to a CA certificate
- a list of paths to a CA certificate
- a buffer of CA certificates
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
AbhiPrasad
commented
Nov 10, 2022
imatwawana
approved these changes
Nov 10, 2022
imatwawana
left a comment
Contributor
There was a problem hiding this comment.
Preview looks good! I just made a small tweak, but otherwise LGTM!
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only can get merged once getsentry/sentry-javascript#6161 is released.
Add documentation for Node Transport options.