Repository navigation
docs(dotnet): Document ClearProviders() in the ASP.NET Core guide for SDK 7.0.0 - #20715
Merged
Merged
Conversation
ClearProviders() after UseSentry removes Sentry's logger providers, as it does for the Generic Host. Mirror the Generic Host guide's section: call UseSentry after ClearProviders(), or add the providers back with Logging.AddSentry(). Closes getsentry/sentry-dotnet#5911 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
jamescrosswell
marked this pull request as ready for review
November 11, 2026 02:59
Contributor
|
Getting ready to monitor this change · Rollout details
|
ric-oliv
approved these changes
Nov 11, 2026
ric-oliv
left a comment
Member
There was a problem hiding this comment.
Looks good!
One optional suggestion inline.
Not for this PR: MAUI and Blazor WebAssembly register their providers through the same HostLoggerProviders.Add (MAUI, WASM). So ClearProviders() after UseSentry removes them there too, and AddSentry() adds them back. Neither one calls WarnIfRemoved, so they log no warning, and neither guide mentions it. It's probably rare, since the MAUI template doesn't clear providers, so it only needs an issue if you think it's worth it.
Co-authored-by: Ricardo Colombo Oliveira <github@ricoliv.com>
6 of 8 tasks
ric-oliv
added a commit
that referenced
this pull request
Nov 15, 2026
## DESCRIBE YOUR PR This updates the .NET docs for sentry-dotnet 7.0.0, which has been on NuGet since 2026-11-12. Each change was reviewed in its own PR against the `dotnet-v7` branch, so the 7.x docs go live together: - #20311 docs(dotnet): Add a Generic Host guide for SDK 7.0.0 - #20642 docs(dotnet): Add supported versions to the MAUI guide for SDK 7.0.0 - #19960 docs(dotnet): Document release and environment resolution for SDK 7.0.0 - #19961 docs(dotnet): Update Microsoft.Extensions.Logging guide for SDK 7.0.0 - #19924 docs(dotnet): Update OTLP propagation docs for SDK 7.0.0 - #19925 docs(dotnet): Update logging docs for SDK 7.0.0 - #20715 docs(dotnet): Document ClearProviders() in the ASP.NET Core guide for SDK 7.0.0 - #20752 docs(dotnet): Tell .NET Framework apps to install Microsoft.Extensions.Logging for SDK 7.0.0 - #20743 docs(dotnet): Document NLog's MinimumLogLevel for SDK 7.0.0 - #20742 docs(dotnet): Link the Generic Host guide from the other .NET pages for SDK 7.0.0 - #20689 docs(dotnet): Update the 7.x migration guide for 7.0.0 - #20780 docs(dotnet): Fix Serilog flushing, Serilog usings and the Azure Functions package for SDK 7.0.0 - #20781 docs(dotnet): Fix the .NET logs and metrics examples and other pages for SDK 7.0.0 ### Issues this closes Closes getsentry/sentry-dotnet#5710 The other docs issues for 7.0.0 were closed when their PRs merged into `dotnet-v7`. ### Before merging - [x] sentry-dotnet 7.0.0 is on NuGet. - [x] The release candidate alert is gone from `includes/dotnet-v7-migration-overview.mdx`. - [x] The links that #20311, #19961 and #19925 left for after the other PRs merge are in. - [x] `master` is merged into `dotnet-v7`, and the Vercel preview looks right. - [x] This description has a `Closes` line for every issue that's still open. ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. Select exactly one option. For deadlines, replace `YYYY-MM-DD` with the due date. You can update this information later by editing the PR description. - [x] Urgent deadline (GA date, etc.): 2026-11-13 - [ ] Other deadline: YYYY-MM-DD - [ ] No deadline: Not urgent, can wait up to 1 week+ --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: James Crosswell <jamescrosswell@users.noreply.github.com> Co-authored-by: ric-oliv <ric-oliv@users.noreply.github.com> Co-authored-by: ric-oliv <5938598+ric-oliv@users.noreply.github.com> Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This targets
dotnet-v7, which collects the .NET docs for sentry-dotnet 7.0.0. #20641 merges that branch intomasterwhen 7.0.0 ships, so this PR can merge intodotnet-v7as soon as it's approved.DESCRIBE YOUR PR
Adds a "Clearing Logger Providers" section to the ASP.NET Core guide, matching the one in the Generic Host guide (#20311). ASP.NET Core's
UseSentryregisters Sentry's logger providers the same way, soClearProviders()after it removes them andILoggerentries stop reaching Sentry. The section says to callUseSentryafterClearProviders(), or to add the providers back withbuilder.Logging.AddSentry().Closes getsentry/sentry-dotnet#5911
Notes for review
Sentry.AspNetCore7.0.0-rc.3.version7hasn't changed this code since rc.3.ClearProviders()beforeUseSentry: a logged warning becomes an event.ClearProviders()afterUseSentry: the SDK starts, but the warning doesn't reach Sentry. WithDebugon, the SDK logs the "logger providers were removed" warning duringStartAsync.AddSentry()afterClearProviders(): the warning becomes an event again, usingMinimumEventLevelfrom theUseSentryoptions.Build()". Here it's "when the app starts", because ASP.NET Core starts the SDK when the host starts (Start the SDK during Build() in ASP.NET Core and Blazor WebAssembly, as the generic host does sentry-dotnet#5815).builder.WebHost.UseSentry()to match the rest of this page, which doesn't use the 7.0builder.UseSentry()overload yet.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace
YYYY-MM-DDwith the due date. You can update this information later by editing the PR description.🤖 Generated with Claude Code