Repository navigation
docs(dotnet): Document TraceIgnoreStatusCodes - #19898
Conversation
Add the option to the .NET options page for the ASP.NET-based guides, and mention it in the ASP.NET Core and ASP.NET tracing pages. The default is empty in 6.x and changes to 301, 305-399 and 401-404 in 7.0.0 (getsentry/sentry-dotnet#5632). Closes getsentry/sentry-dotnet#5708 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Co-authored-by: James Crosswell <jamescrosswell@users.noreply.github.com>
|
The plan checks client errors on the changed pages, page-load counts, and error logs from those routes. An issue escalates when client errors rise or those pages stop loading. Monitoring in Services: Mention PlanWhat changedThe .NET options page now documents TraceIgnoreStatusCodes for inbound HTTP tracing. The ASP.NET and ASP.NET Core tracing pages now say which status codes skip transactions. sentry-docs must deploy to production before this text is live. RiskA broken MDX block can fail the options page for every .NET guide. New code samples can throw in the client code tabs. A static build failure stops the deploy before users see the pages. Intended effectThis change is a documentation edit. Telemetry cannot show that the new text is on the page. Confirmed means the three live pages include TraceIgnoreStatusCodes. Absent means those pages still omit the option. The pages are Regression watchThis diff can break MDX render and code tabs on the .NET options page and on inherited guide copies of that page.
If error counts rise, inspect client exceptions on the options page and on the two tracing pages. Check code tabs and platform-section render first. Not observableCorrectness of the new option text has no telemetry. Page-load latency for these routes is not available. Client transactions do not use the URL path as the transaction name. The 404 metric stores only the first two path segments, so it cannot isolate these pages. |
Co-authored-by: Ricardo Colombo Oliveira <github@ricoliv.com>
ric-oliv
left a comment
There was a problem hiding this comment.
Nice! Just added a few suggestions inline, nothing blocking though.
Two things outside the diff:
- The note in the PR description says the
[]/[0]caveat is worded as 7.0.0-only, but 6ca5bdc dropped that qualifier. The text is still true on 6.x, so only the description needs updating. - The .NET migration guide has no 7.x section yet. The Migration section in getsentry/sentry-dotnet#5632 is ready to copy. Worth tracking before the 7.0.0 release.
Co-authored-by: Ricardo Colombo Oliveira <github@ricoliv.com>
|
Verified in
|
….0 (#19960) > [!NOTE] > This targets `dotnet-v7`, which collects the .NET docs for sentry-dotnet 7.0.0. #20641 merges that branch into `master` when 7.0.0 ships, so this PR can merge into `dotnet-v7` as soon as it's approved. ## DESCRIBE YOUR PR Documents how the .NET SDK resolves its default release and environment from 7.0.0 on (getsentry/sentry-dotnet#5671 and getsentry/sentry-dotnet#5703). The .NET docs aren't versioned, so the text is written for 7.x, with a short "Before version 7.0.0" note where a 6.x reader would otherwise be misled. - **Options > `Release`**: `SENTRY_RELEASE` is read first, then the app package on Android, iOS and Mac Catalyst, or the entry assembly elsewhere. Removes the JavaScript SDK's `window.SENTRY_RELEASE` aside. - **Options > `Environment`**: the precedence (code or configuration, `SENTRY_ENVIRONMENT`, then the host environment in ASP.NET Core, Blazor WebAssembly and Google Cloud Functions, then `debug`/`production`), the casing rule and `AdjustStandardEnvironmentNameCasing`, and that `Scope.Environment` now applies to every kind of telemetry, with `null` clearing it. - **Releases page** (`set-release` include): adds the Android, iOS and Mac Catalyst default, `<package-id>@<version>+<build>`, and where its parts come from. - **Environments page** (`set-environment` include): points to the option for the defaults, and shows overriding the environment on the scope. Closes getsentry/sentry-dotnet#5709 ### Notes for review All of this was checked against the `version7` source rather than the issue text. Where the two differ: - The app-package release default also applies on **Mac Catalyst**, not just Android and iOS. It sits behind `#if ANDROID || __IOS__`, and the Mac Catalyst SDK defines `__IOS__`. - The issue says `Scope.Release` and `Scope.Distribution` going away means release and distribution "can only be set on `SentryOptions`". That's not quite right: `SentryEvent`, transactions and check-ins still have their own `Release`. These pages don't cover that, and the removal belongs in the migration guide (getsentry/sentry-dotnet#5710). - The host-environment mapping covers every ASP.NET Core `UseSentry` overload, including the `ISentryBuilder` ones that gRPC apps use, so the docs just say "ASP.NET Core". Generic Host apps (worker services) are listed ahead of getsentry/sentry-dotnet#5572, which is expected to map the host environment the same way and merge before 7.0.0. Check that it does before merging this. MAUI still falls back to `debug`/`production`. Left unchanged: - The Google Cloud Functions guide already says "Environment is automatically set (IHostingEnvironment)". That wasn't true in 6.x, but it is from 7.0.0. The ASP.NET Core guide's Environment section is also correct for 7.x. The Blazor WebAssembly guide doesn't mention the environment, and there's no gRPC page. - There's no "Before version 7.0.0" note for Blazor WebAssembly, Google Cloud Functions and the `ISentryBuilder` overloads starting to read the host environment. Add one if you think 6.x readers need it. - Edits to `options.mdx` stay inside the `Release` and `Environment` entries, so they shouldn't conflict with #19897 (Hooks) or #19898 (tracing options). ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. Select exactly one option. For deadlines, replace `YYYY-MM-DD` with the due date. You can update this information later by editing the PR description. - [x] Urgent deadline (GA date, etc.): 2026-11-30 - [ ] Other deadline: YYYY-MM-DD - [ ] No deadline: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've supplied a deadline. Thanks in advance for your help! ## PRE-MERGE CHECKLIST _Make sure you've checked the following before merging your changes:_ - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Ricardo Colombo Oliveira <github@ricoliv.com> Co-authored-by: ric-oliv <ric-oliv@users.noreply.github.com>
DESCRIBE YOUR PR
Documents
SentryOptions.TraceIgnoreStatusCodesfor the .NET SDK. The option shipped in 6.4.0 (getsentry/sentry-dotnet#5034), but the .NET docs don't mention it. In 7.0.0 its default changes from an empty list to 301, 305–399 and 401–404 (getsentry/sentry-dotnet#5632), so ASP.NET Core and ASP.NET apps will stop sending transactions for those responses.SdkOptionentry to the Tracing Options on the shared .NET options page. It covers what the option filters, how to set codes and ranges, the 7.0.0 default and why 302/303 aren't in it, how to trace everything again, andappsettings.json.Notes for review:
PlatformSectionfor the guides that run Sentry's ASP.NET or ASP.NET Core integration: ASP.NET, ASP.NET Core, Blazor Server, AWS Lambda and Google Cloud Functions. The option has no effect elsewhere.HttpClientrequests aren't affected" holds from 6.12.0 (getsentry/sentry-dotnet#5643). From 6.4.0 to 6.11.x, an app usingUseOpenTelemetrythat set the option could also lose roothttp.clienttransactions whose downstream status matched. I left that fixed bug off the page.UseOtlp, spans go straight to Sentry's OTLP endpoint and never reach the SDK's transaction processors, so the option doesn't apply. The page says so in one line.[]vs[0]caveat forappsettings.jsononly matters from 7.0.0, when the default is non-empty, and is worded that way. Configuration can't express ranges yet (getsentry/sentry-dotnet#5644).Closes getsentry/sentry-dotnet#5708
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace
YYYY-MM-DDwith the due date. You can update this information later by editing the PR description.PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
🤖 Generated with Claude Code