feat(javascript): Add documentation for injecting Html <meta> tags
#10926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Lms24
requested review from
a team,
mydea and
nicohrubec
and removed request for
a team
Bundle ReportChanges will decrease total bundle size by 15 bytes ⬇️
|
lizokm
approved these changes
Jul 31, 2024
Contributor
lizokm
left a comment
lizokm
left a comment
There was a problem hiding this comment.
Thanks for updating this!!
platform-includes/distributed-tracing/custom-instrumentation/javascript.mdx
Outdated
Show resolved
Hide resolved
mydea
reviewed
Aug 1, 2024
platform-includes/distributed-tracing/custom-instrumentation/javascript.mdx
Outdated
Show resolved
Hide resolved
mydea
reviewed
Aug 1, 2024
platform-includes/distributed-tracing/custom-instrumentation/javascript.mdx
Outdated
Show resolved
Hide resolved
mydea
reviewed
Aug 1, 2024
| <Note> | ||
| This setup is only required if you have a custom SSR or HTML page generation setup. |
Member
There was a problem hiding this comment.
Can we avoid showing this note, and simply only show this whole section for relevant SDKs? So hide it for next, remix etc?
Member
Author
There was a problem hiding this comment.
Yeah let's try this first. We can always expand the allowlist if users are asking for it.
Member
Author
There was a problem hiding this comment.
Ok, updated to notSupported=['browser'] which makes this section also dissappear for meta framework SDKs
Co-authored-by: Liza Mock <[email protected]> Co-authored-by: Francesco Novy <[email protected]>
Lms24
commented
Aug 6, 2024
platform-includes/distributed-tracing/custom-instrumentation/javascript.mdx
Outdated
Show resolved
Hide resolved
Lms24
changed the title
getMetaTagValues function<meta> tags
Member
Author
|
I adjusted the PR to accommodate both new functions we created for meta tag injection (see updated description). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged after getsentry/sentry-javascript#13201 is released.
This PR adds documentation for
getTraceDataintroduced in feat(core): AddgetTraceDatafunction sentry-javascript#13134getTraceMetaTagsintroduced in feat(core): AddgetTraceMetaTagsfunction sentry-javascript#13201which both give users the ability to propagate backend -> frontend traces via
<meta>Html tags.closes #7671