Repository navigation
feat: remove enableLogs option in v10 - #8769
Merged
Merged
Conversation
In SDK_V10, logs are always on. Gate enableLogs behind #if !SDK_V10 and drop v10 call sites that set or test it. Co-Authored-By: Noah Martin <noah.martin@sentry.io>
Contributor
|
📲 Install BuildsiOS
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a879c92 | 1229.37 ms | 1262.33 ms | 32.97 ms |
| e668bb1 | 1208.15 ms | 1246.62 ms | 38.48 ms |
| 0ce4b11 | 1231.38 ms | 1254.59 ms | 23.22 ms |
| caad37c | 1234.35 ms | 1264.18 ms | 29.83 ms |
| cf226b0 | 1217.35 ms | 1254.55 ms | 37.20 ms |
| e3070ad | 1201.60 ms | 1235.70 ms | 34.10 ms |
| 29d1b7f | 1220.58 ms | 1254.14 ms | 33.56 ms |
| 69745fc | 1226.70 ms | 1259.72 ms | 33.02 ms |
| 4d144d7 | 1225.77 ms | 1255.85 ms | 30.09 ms |
| 2c9ee54 | 1226.87 ms | 1251.10 ms | 24.23 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a879c92 | 24.14 KiB | 1.25 MiB | 1.23 MiB |
| e668bb1 | 24.14 KiB | 1.27 MiB | 1.24 MiB |
| 0ce4b11 | 24.14 KiB | 1.17 MiB | 1.15 MiB |
| caad37c | 24.14 KiB | 1.20 MiB | 1.17 MiB |
| cf226b0 | 24.14 KiB | 1.24 MiB | 1.21 MiB |
| e3070ad | 24.14 KiB | 1.16 MiB | 1.14 MiB |
| 29d1b7f | 24.14 KiB | 1.26 MiB | 1.23 MiB |
| 69745fc | 24.14 KiB | 1.15 MiB | 1.13 MiB |
| 4d144d7 | 24.14 KiB | 1.17 MiB | 1.15 MiB |
| 2c9ee54 | 24.14 KiB | 1.17 MiB | 1.15 MiB |
noahsmartin
marked this pull request as ready for review
August 11, 2026 18:27
noahsmartin
requested review from
NinjaLikesCheez,
itaybre,
noahsmartin,
philippsuess and
philprime
as code owners
August 11, 2026 18:27
5 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
In v10, remove
Options.enableLogsentirely. Logs are always enabled. Keep the option only for pre-v10 builds behind#if !SDK_V10.This replaces the v10 default flip from #8717. Call sites no longer need to opt in, and apps cannot disable logs through this flag in v10.
💡 Motivation and Context
Logging should be always-on in the next major. Shipping a default of
truestill leaves a public kill switch. Removing the option makes that contract explicit and simplifies Options.Changes
enableLogsout ofOptions, dictionary init, and the ObjC wrapper underSDK_V10SentryClientunderSDK_V10SDK_V10sdk_api_v10.json/sdk_api_objc_v10.jsonCHANGELOG_V10.md💚 How did you test it?
#if SDK_V10/#if !SDK_V10patterns used by other removed options (for example standalone app starts)make build-ios/make test-iosormake generate-public-apihere (no Xcode in this environment). Please run locally or rely on CI:make build-ios FOR_AGENTS=truemake build-ios-v10 FOR_AGENTS=true(or the repo v10 build target)make test-ios FOR_AGENTS=true ONLY_TESTING=SentryTests/SentryOptionsTest,SentryTests/SentryClientTests,SentryTests/SentrySDKTestsmake generate-public-apiif CI reports API snapshot drift📝 Checklist
sendDefaultPiiis enabled.#skip-changelog
Requested by Noah Martin.
--
View Junior Session [Sentry]