Skip to content

feat: remove enableLogs option in v10 - #8769

Merged
itaybre merged 2 commits into
mainfrom
feat/remove-enable-logs-v10
Aug 11, 2026
Merged

itaybre merged 2 commits into
mainfrom
feat/remove-enable-logs-v10

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

📜 Description

In v10, remove Options.enableLogs entirely. Logs are always enabled. Keep the option only for pre-v10 builds behind #if !SDK_V10.

This replaces the v10 default flip from #8717. Call sites no longer need to opt in, and apps cannot disable logs through this flag in v10.

💡 Motivation and Context

Logging should be always-on in the next major. Shipping a default of true still leaves a public kill switch. Removing the option makes that contract explicit and simplifies Options.

Changes

  • Gate enableLogs out of Options, dictionary init, and the ObjC wrapper under SDK_V10
  • Skip the enableLogs drop check in SentryClient under SDK_V10
  • Make the Swift helper always report logs enabled under SDK_V10
  • Update samples/tests that set or assert the flag so they compile without it in v10
  • Remove the symbol from sdk_api_v10.json / sdk_api_objc_v10.json
  • Document the breaking change in CHANGELOG_V10.md

💚 How did you test it?

  • Source and test call sites reviewed against #if SDK_V10 / #if !SDK_V10 patterns used by other removed options (for example standalone app starts)
  • Could not run make build-ios / make test-ios or make generate-public-api here (no Xcode in this environment). Please run locally or rely on CI:
    • make build-ios FOR_AGENTS=true
    • make build-ios-v10 FOR_AGENTS=true (or the repo v10 build target)
    • make test-ios FOR_AGENTS=true ONLY_TESTING=SentryTests/SentryOptionsTest,SentryTests/SentryClientTests,SentryTests/SentrySDKTests
    • make generate-public-api if CI reports API snapshot drift

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.
  • Public API changes reviewed by another Mobile SDK team member or implemented according to the develop docs spec.
  • If I added a new public API, I also added it to the SentryObjC wrapper.

#skip-changelog

Requested by Noah Martin.

--

View Junior Session [Sentry]

In SDK_V10, logs are always on. Gate enableLogs behind
#if !SDK_V10 and drop v10 call sites that set or test it.

Co-Authored-By: Noah Martin <noah.martin@sentry.io>
@github-actions

github-actions Bot commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against a579ad9

@noahsmartin noahsmartin added the run-full-ci Allows gated GitHub Action workflows to run for a labelled pull request label Aug 11, 2026
@sentry

sentry Bot commented Aug 11, 2026

Copy link
Copy Markdown

📲 Install Builds

iOS

🔗 App Name App ID Version Configuration
SDK-Size io.sentry.sample.SDK-Size 9.25.0 (1) Release

⚙️ sentry-cocoa Build Distribution Settings

@github-actions

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1222.65 ms 1261.52 ms 38.88 ms
Size 24.14 KiB 1.29 MiB 1.27 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a879c92 1229.37 ms 1262.33 ms 32.97 ms
e668bb1 1208.15 ms 1246.62 ms 38.48 ms
0ce4b11 1231.38 ms 1254.59 ms 23.22 ms
caad37c 1234.35 ms 1264.18 ms 29.83 ms
cf226b0 1217.35 ms 1254.55 ms 37.20 ms
e3070ad 1201.60 ms 1235.70 ms 34.10 ms
29d1b7f 1220.58 ms 1254.14 ms 33.56 ms
69745fc 1226.70 ms 1259.72 ms 33.02 ms
4d144d7 1225.77 ms 1255.85 ms 30.09 ms
2c9ee54 1226.87 ms 1251.10 ms 24.23 ms

App size

Revision Plain With Sentry Diff
a879c92 24.14 KiB 1.25 MiB 1.23 MiB
e668bb1 24.14 KiB 1.27 MiB 1.24 MiB
0ce4b11 24.14 KiB 1.17 MiB 1.15 MiB
caad37c 24.14 KiB 1.20 MiB 1.17 MiB
cf226b0 24.14 KiB 1.24 MiB 1.21 MiB
e3070ad 24.14 KiB 1.16 MiB 1.14 MiB
29d1b7f 24.14 KiB 1.26 MiB 1.23 MiB
69745fc 24.14 KiB 1.15 MiB 1.13 MiB
4d144d7 24.14 KiB 1.17 MiB 1.15 MiB
2c9ee54 24.14 KiB 1.17 MiB 1.15 MiB

@noahsmartin
noahsmartin marked this pull request as ready for review August 11, 2026 18:27
@noahsmartin
noahsmartin requested a review from a team August 11, 2026 18:27

@itaybre itaybre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itaybre
itaybre merged commit 4f45d12 into main Aug 11, 2026
365 of 391 checks passed
@itaybre
itaybre deleted the feat/remove-enable-logs-v10 branch August 11, 2026 18:49
@itaybre itaybre mentioned this pull request Aug 11, 2026
5 of 9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved run-full-ci Allows gated GitHub Action workflows to run for a labelled pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants