Skip to content

build(deps): Fix npm audit vulnerabilities via eslint-config-sentry-app upgrade #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oioki merged 2 commits into from
Feb 27, 2026
Merged

build(deps): Fix npm audit vulnerabilities via eslint-config-sentry-app upgrade #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
899323b
build(deps): Fix npm audit vulnerabilities via eslint-config-sentry-a…
oioki Feb 27, 2026
41158ce
build(deps): Update yarn.lock with platform resolver bindings
oioki Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"@types/supertest": "^7.2.0",
"@types/yargs": "^17.0.32",
"eslint": "^8.56.0",
"eslint-config-sentry-app": "^1.129.0",
"eslint-config-sentry-app": "^2.10.0",
Copy link

@cursor cursor bot Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint 8.56.0 below @typescript-eslint 8.x minimum requirement

Medium Severity

The eslint-config-sentry-app 2.x upgrade brings in @typescript-eslint 8.x (resolved to 8.56.1 in the lockfile), which requires eslint ^8.57.0 || ^9.0.0 as a peer dependency. However, eslint remains specified as ^8.56.0 and is lockfile-pinned to 8.56.0, which does not satisfy ^8.57.0. The PR description incorrectly states the peer requirement is >=8. The eslint version specifier needs to be bumped to at least ^8.57.0.

Fix in Cursor Fix in Web

"jest": "^29.7.0",
"jest-fetch-mock": "^3.0.3",
"jest-image-snapshot": "5.1.0",
Copy link

@sentry sentry bot Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The resolutions field in package.json forces minimatch to 9.0.9, which is incompatible with dependencies requiring minimatch@^3.x or minimatch@^10.x, violating semantic versioning.
Severity: MEDIUM

Suggested Fix

Remove the minimatch entry from the resolutions block in package.json. This will allow yarn to resolve the correct versions of minimatch for each dependency according to their specified semantic versioning ranges, preventing potential API incompatibilities and runtime errors.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: package.json#L43

Potential issue: The `resolutions` field in `package.json` pins `minimatch` to version
`9.0.9` for all dependencies. However, the dependency tree requires other major
versions, such as `^3.x` and `^10.x`. Forcing version `9.0.9` violates the semantic
versioning contract for these packages. This can lead to runtime errors or unexpected
behavior when a dependency attempts to use an API or feature from `minimatch` that has
changed between major versions. For example, a package expecting `minimatch@^3.1.2`
might fail if an expected API from the 3.x series is different or absent in version 9.x.

Did we get this right? 👍 / 👎 to inform future reviews.

Expand Down
Loading
Loading