show docker build output (#785) #882
Conversation
src/popper/runner_host.py
Outdated
| if not self._config.dry_run: | ||
| self._d.images.build( | ||
|
|
||
| _, build_logs = self._d.images.build( |
There was a problem hiding this comment.
this blocks, so the output only shows until images.build() returns. If the output of the build is too big, this might cause memory issues. In order to avoid this, this code can use the low-level API as exemplified here. Very similar to what what's already here, but with a couple of tweaks.
|
thanks! I made some tweaks based on what you have in this PR and pushed them to https://github.com/getpopper/popper/tree/pr/882 . Does all that make sense to you? If it does, can you please rebase that branch from this PR? |
|
nice! I did the rebase and it works smoothly. |
|
great, thanks! can you please push the changes to this PR, so I can merge from here? otherwise your authorship is going to get lost. |
|
sure 😁 |
|
thanks! |
2 participants
Shows docker build output by default and when the
--quiet flagis given topopper runit hides it.