Implementation of Docker container options for steps #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jswig
commented
Jul 13, 2020
| "matching-rule": "any", | ||
| "mapping": {"regex;(.+)": {"type": "str"}}, | ||
| }, | ||
| "options": {"type": "map", "allowempty": True}, |
Contributor
Author
There was a problem hiding this comment.
Preferred to keep the yml validation simple as it would be unwieldy to specify all allowable options for all container runtimes
Jswig
commented
Jul 13, 2020
|
|
||
| self._update_with_engine_config(args) | ||
|
|
||
| args.update(step.options) |
Contributor
Author
There was a problem hiding this comment.
after update_with_engine_config to ensure overall configuration is overriden
Jswig
changed the title
ivotron
requested changes
Jul 14, 2020
Collaborator
ivotron
left a comment
ivotron
left a comment
There was a problem hiding this comment.
this looks great! The only other thing that it could be added is documentation. Would it be possible to include add a new attribute to this table, with a note specifying that this is only available for Docker.
Also, a couple of sentences can be included in the Custom Engine Configuration section that mention that this can be done at the level of a step.
Collaborator
|
thanks @Jswig !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains changes allowing to pass step-specific container options to the Docker runner.
Edited some tests to reflect new behavior.